Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wizards/foundation): Added missing DAI bTypes #1320

Merged
merged 1 commit into from
Sep 12, 2023
Merged

fix(wizards/foundation): Added missing DAI bTypes #1320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/wizards/foundation/dai-field-type.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,11 @@ const daiFieldTypes = [
'VisString65',
'VisString129',
'VisString255',
'ObjRef',
'Currency',
'Octet64',
'Octet6',
'Octet16',
] as const;
export type DaiFieldTypes = typeof daiFieldTypes[number];
const emptyIfNull = <T>(item: T | null, value: string): string => {
Expand Down Expand Up @@ -65,6 +70,11 @@ export function getCustomField(): Record<DaiFieldTypes, CustomField> {
VisString65: stringField('VisString65', 65),
VisString129: stringField('VisString129', 129),
VisString255: stringField('VisString255', 255),
ObjRef: stringField('VisString129', 129),
Currency: stringField('Currency', 3),
Octet64: stringField('Octet64', 64 * 2),
Octet6: stringField('Octet6', 6 * 2),
Octet16: stringField('Octet16', 16 * 2),
};

function booleanField(): CustomField {
Expand Down
3 changes: 3 additions & 0 deletions src/wizards/foundation/enums.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,10 @@ export const predefinedBasicTypeEnum = [
'TrgOps',
'OptFlds',
'SvOptFlds',
'LogOptFlds',
'EntryID',
'Octet6',
'Octet16',
];

export const valKindEnum = ['Spec', 'Conf', 'RO', 'Set'];
Expand Down
54 changes: 54 additions & 0 deletions test/integration/wizards/__snapshots__/bda-wizarding-editing.test.snap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,15 @@ snapshots["BDA wizarding editing integration defines a editBDaWizard to edit an
>
SvOptFlds
</mwc-list-item>
<mwc-list-item
aria-disabled="false"
mwc-list-item=""
role="option"
tabindex="-1"
value="LogOptFlds"
>
LogOptFlds
</mwc-list-item>
<mwc-list-item
aria-disabled="false"
mwc-list-item=""
Expand All @@ -375,6 +384,24 @@ snapshots["BDA wizarding editing integration defines a editBDaWizard to edit an
>
EntryID
</mwc-list-item>
<mwc-list-item
aria-disabled="false"
mwc-list-item=""
role="option"
tabindex="-1"
value="Octet6"
>
Octet6
</mwc-list-item>
<mwc-list-item
aria-disabled="false"
mwc-list-item=""
role="option"
tabindex="-1"
value="Octet16"
>
Octet16
</mwc-list-item>
</wizard-select>
<wizard-select
fixedmenuposition=""
Expand Down Expand Up @@ -967,6 +994,15 @@ snapshots["BDA wizarding editing integration defines a createBDaWizard to create
>
SvOptFlds
</mwc-list-item>
<mwc-list-item
aria-disabled="false"
mwc-list-item=""
role="option"
tabindex="-1"
value="LogOptFlds"
>
LogOptFlds
</mwc-list-item>
<mwc-list-item
aria-disabled="false"
mwc-list-item=""
Expand All @@ -976,6 +1012,24 @@ snapshots["BDA wizarding editing integration defines a createBDaWizard to create
>
EntryID
</mwc-list-item>
<mwc-list-item
aria-disabled="false"
mwc-list-item=""
role="option"
tabindex="-1"
value="Octet6"
>
Octet6
</mwc-list-item>
<mwc-list-item
aria-disabled="false"
mwc-list-item=""
role="option"
tabindex="-1"
value="Octet16"
>
Octet16
</mwc-list-item>
</wizard-select>
<wizard-select
fixedmenuposition=""
Expand Down
54 changes: 54 additions & 0 deletions test/integration/wizards/__snapshots__/da-wizarding-editing.test.snap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,15 @@ snapshots["DA wizarding editing integration defines a editDaWizard to edit an ex
>
SvOptFlds
</mwc-list-item>
<mwc-list-item
aria-disabled="false"
mwc-list-item=""
role="option"
tabindex="-1"
value="LogOptFlds"
>
LogOptFlds
</mwc-list-item>
<mwc-list-item
aria-disabled="false"
mwc-list-item=""
Expand All @@ -375,6 +384,24 @@ snapshots["DA wizarding editing integration defines a editDaWizard to edit an ex
>
EntryID
</mwc-list-item>
<mwc-list-item
aria-disabled="false"
mwc-list-item=""
role="option"
tabindex="-1"
value="Octet6"
>
Octet6
</mwc-list-item>
<mwc-list-item
aria-disabled="false"
mwc-list-item=""
role="option"
tabindex="-1"
value="Octet16"
>
Octet16
</mwc-list-item>
</wizard-select>
<wizard-select
fixedmenuposition=""
Expand Down Expand Up @@ -1156,6 +1183,15 @@ snapshots["DA wizarding editing integration defines a createDaWizard to create a
>
SvOptFlds
</mwc-list-item>
<mwc-list-item
aria-disabled="false"
mwc-list-item=""
role="option"
tabindex="-1"
value="LogOptFlds"
>
LogOptFlds
</mwc-list-item>
<mwc-list-item
aria-disabled="false"
mwc-list-item=""
Expand All @@ -1165,6 +1201,24 @@ snapshots["DA wizarding editing integration defines a createDaWizard to create a
>
EntryID
</mwc-list-item>
<mwc-list-item
aria-disabled="false"
mwc-list-item=""
role="option"
tabindex="-1"
value="Octet6"
>
Octet6
</mwc-list-item>
<mwc-list-item
aria-disabled="false"
mwc-list-item=""
role="option"
tabindex="-1"
value="Octet16"
>
Octet16
</mwc-list-item>
</wizard-select>
<wizard-select
fixedmenuposition=""
Expand Down
24 changes: 24 additions & 0 deletions test/unit/wizards/__snapshots__/abstractda.test.snap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,14 @@ snapshots["abstractda wizards renderWizard looks like the latest snapshot"] =
>
SvOptFlds
</mwc-list-item>
<mwc-list-item
aria-disabled="false"
mwc-list-item=""
tabindex="-1"
value="LogOptFlds"
>
LogOptFlds
</mwc-list-item>
<mwc-list-item
aria-disabled="false"
mwc-list-item=""
Expand All @@ -313,6 +321,22 @@ snapshots["abstractda wizards renderWizard looks like the latest snapshot"] =
>
EntryID
</mwc-list-item>
<mwc-list-item
aria-disabled="false"
mwc-list-item=""
tabindex="-1"
value="Octet6"
>
Octet6
</mwc-list-item>
<mwc-list-item
aria-disabled="false"
mwc-list-item=""
tabindex="-1"
value="Octet16"
>
Octet16
</mwc-list-item>
</wizard-select>
<wizard-select
fixedmenuposition=""
Expand Down
Loading