Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reduce items on menu if elsewhere in the UI #1256

Merged
merged 4 commits into from
May 10, 2023
Merged

fix: reduce items on menu if elsewhere in the UI #1256

merged 4 commits into from
May 10, 2023

Conversation

Stef3st
Copy link
Contributor

@Stef3st Stef3st commented May 9, 2023 •
edited
Loading

closes #1241

@Stef3st Stef3st self-assigned this May 9, 2023
@Stef3st Stef3st linked an issue May 9, 2023 that may be closed by this pull request
Reduce items on menu if available elsewhere in the UI #1241
Closed
danyill
danyill requested changes May 10, 2023
View reviewed changes
Copy link
Collaborator

@danyill danyill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for attending to this 👍

However I can't open the "Import IEDs", "Settings" or "Extensions" menu items with this PR when I did some local testing so I think perhaps other modifications are required elsewhere otherwise the menu is not in synch with some other data source?

@Stef3st
Copy link
Contributor Author

Stef3st commented May 10, 2023

Thank you for attending to this 👍

However I can't open the "Import IEDs", "Settings" or "Extensions" menu items with this PR when I did some local testing so I think perhaps other modifications are required elsewhere otherwise the menu is not in synch with some other data source?

Thank you for checking it out, I'll look at it and let you know when Ive got a solution for this!

@Stef3st Stef3st requested a review from danyill May 10, 2023 07:27
@Stef3st
Copy link
Contributor Author

Stef3st commented May 10, 2023

@danyill fixed the problem. It still tried to render menu items that weren't created any more. Should work fine now!

danyill
danyill approved these changes May 10, 2023
View reviewed changes
Copy link
Collaborator

@danyill danyill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Stef3st Stef3st merged commit ed41def into main May 10, 2023
@Stef3st Stef3st deleted the 1241-reduce-items-on-menu-if-available-elsewhere-in-the-ui branch May 10, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danyill danyill danyill approved these changes

@juancho0202 juancho0202 Awaiting requested review from juancho0202

@pascalwilbrink pascalwilbrink Awaiting requested review from pascalwilbrink

Assignees

@Stef3st Stef3st

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce items on menu if available elsewhere in the UI
2 participants
@Stef3st @danyill