feat(openscd):Add multiple Val element into DAI distinguished by sGroup #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juancho0202
added
Kind: Enhancement
juancho0202
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
pascalwilbrink
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to reviewer:
My approach is to mod all the custom fields in
dai-field-type.tsso that both the render and value functions include an extra parameter callednumOfSGsand modify their behavior accordingly when the param is present.I tested this initially by modifying the
test\testfiles\wizards\ied.scdfile so that theScaledValueConfigDA would comply with all the conditions described in #1139 and it seems to be doing the job nicely, but I would prefer if some IEC 61850 expert in the room could step up and help me build a proper file for testing this functionality.