Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(update-actions): Update Node from 14.x to 18.x #1192

Merged
merged 3 commits into from
Mar 13, 2023
Merged

chore(update-actions): Update Node from 14.x to 18.x #1192

merged 3 commits into from
Mar 13, 2023

Conversation

apupier
Copy link
Contributor

@apupier apupier commented Mar 3, 2023

  • updated GitHub Actions
  • provide information in readme on the version to use

fixes #918

@apupier @ca-d
chore: Update Node from 14.x to 18.x
da1bac0 
- updated GitHub Actions
- provide information in readme on the version to use

fixes openscd#918

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
ca-d
ca-d previously approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@ca-d ca-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the contribution and welcome to the project!

If you want some help overcoming our desperately lacking developer documentation, please feel free to join the #open-scd channel on lfenergy.slack.com and say hi! 👋

@ca-d
fix: explicitly depend on source-map
7b31191 
Adds a "source-map" dev dependency to package.json to fix the version to
one where mozilla/source-map#432 is not an
issue.
@ca-d
Copy link
Contributor

ca-d commented Mar 7, 2023 •
edited
Loading

I'm sorry for pushing directly to your fork, I intended to push to my own fork and send a pull request describing an issue with an older version of some upstream development dependency and the new node version. I was surprised to find that I could simply push the change to your fork.

ca-d
ca-d approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@ca-d ca-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still LGTM

@apupier
Copy link
Contributor Author

apupier commented Mar 8, 2023

I'm sorry for pushing directly to your fork

No problem, I always Allow edits and access to secrets by maintainers anyway as they are better placed than the newcomer me to know how to improve the codebase.

@danyill
Copy link
Collaborator

danyill commented Mar 12, 2023

hey @apupier - around here with approval, contributors merge their own PRs (not, I think, that we told anyone that 😉).

I'd be keen for you to merge this when you can as it would be convenient for me too. Thanks for this PR.

@apupier
Copy link
Contributor Author

apupier commented Mar 13, 2023

I do not have rights to merge it:

image

@danyill
Copy link
Collaborator

danyill commented Mar 13, 2023

I do not have rights to merge it:

Oh sorry, how annoying. I'll do it.

@danyill danyill changed the title chore: Update Node from 14.x to 18.x chore(update-actions): Update Node from 14.x to 18.x Mar 13, 2023
@danyill danyill merged commit 5bded32 into openscd:main Mar 13, 2023
@apupier apupier deleted the 918-upgradeNodeJS branch March 13, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ca-d ca-d ca-d approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade GitHub Actions to use newer version of NodeJS/NPM
4 participants
@apupier @ca-d @danyill @Sander3003