Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editors/cleanup): quote input in selector of control blocks cleanup editor, closes #1145 #1146

Merged

Conversation

danyill
Copy link
Collaborator

@danyill danyill commented Jan 25, 2023

Closes #1145

I don't think this requires any new tests but if you think otherwise, please let me know.

@danyill danyill changed the title Quote input in selector of control blocks cleanup editor, closes #1145 fix(editors/cleanup) Quote input in selector of control blocks cleanup editor, closes #1145 Jan 25, 2023
@JakobVogelsang JakobVogelsang changed the title fix(editors/cleanup) Quote input in selector of control blocks cleanup editor, closes #1145 fix(editors/cleanup): quote input in selector of control blocks cleanup editor, closes #1145 Jan 27, 2023
Copy link
Collaborator

@JakobVogelsang JakobVogelsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@juancho0202 juancho0202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Howdy! 🤠 LGTMT

@danyill danyill merged commit ae26764 into openscd:main Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SyntaxError at src/editors/cleanup/control-blocks-container.js
3 participants