Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: styling issue with SubEquipment editor #1130

Merged
merged 2 commits into from
Jan 14, 2023

Conversation

JakobVogelsang
Copy link
Collaborator

Closes #1129

Two things that have been fixed

  1. by mistake, the container for sub-equipment-editors was declared min size 64px. That is why it looked too strange. This declaration is only necessary for icon type components. SubEquipment is never rendered as icon.
  2. sub-equipment-editor do not need to be within a container. That is only necessary when grid type display is used. E.g. Bay within VoltageLevel or ConductingEquipment as icon within Bay. In all other cases, just adding it as child editor is enough. action-pane will do all the styling.

There is no regression test as I only touched CSS. Just updated snapshots due to the changes html

Copy link
Collaborator

@danyill danyill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JakobVogelsang JakobVogelsang merged commit d0e9657 into main Jan 14, 2023
@JakobVogelsang JakobVogelsang deleted the fix-sub-equipement-styling-issue branch January 14, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Substation Editor doesn't handle SubEquipment Functions and SubFunctions element overflow
2 participants