-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wizards/services): add read-only wizard on access point and ied #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
…thin the IED. The Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Don't show the wizard pages if no content is available Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
…y filtered out) Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
@pascalwilbrink can you finish this pull-request? I would like get in into production. |
Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
JakobVogelsang
changed the title
Services wizard (WIP)
feat(wizards/services): add read-only wizard on access point and ied
Feb 7, 2023
JakobVogelsang
requested changes
Feb 7, 2023
test/unit/editors/ied/__snapshots__/access-point-container.test.snap.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Changed the check if a wizard page should be shown to a more `complex` function. Added tests for that function Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
…properties Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
…09_Services_Edit_Wizard
Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
JakobVogelsang
approved these changes
Feb 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #909
Fixes #878
Fixes #887
Fixes #908
Fixes #893
Fixes #907
Signed-off-by: Pascal Wilbrink pascal.wilbrink@alliander.com