Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plain-compare-list): swap list relations #1096

Merged
merged 2 commits into from
Nov 28, 2022
Merged

fix(plain-compare-list): swap list relations #1096

merged 2 commits into from
Nov 28, 2022

Conversation

pascalwilbrink
Copy link
Member

@pascalwilbrink pascalwilbrink commented Nov 28, 2022 •
edited
Loading

closes #1094

@JakobVogelsang JakobVogelsang changed the title 1094 fix plain compare list fix(plain-compare-list): ?? Nov 28, 2022
@pascalwilbrink pascalwilbrink changed the title fix(plain-compare-list): ?? fix(plain-compare-list): 1094 Nov 28, 2022
@JakobVogelsang JakobVogelsang changed the title fix(plain-compare-list): 1094 fix(plain-compare-list): swap list with right list Nov 28, 2022
JakobVogelsang
JakobVogelsang approved these changes Nov 28, 2022
View reviewed changes
Copy link
Collaborator

@JakobVogelsang JakobVogelsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JakobVogelsang JakobVogelsang changed the title fix(plain-compare-list): swap list with right list fix(plain-compare-list): swap list relations Nov 28, 2022
@JakobVogelsang JakobVogelsang merged commit 9fbfbcd into main Nov 28, 2022
@JakobVogelsang JakobVogelsang deleted the 1094_Fix_Plain_Compare_List branch November 28, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakobVogelsang JakobVogelsang JakobVogelsang approved these changes

@juancho0202 juancho0202 Awaiting requested review from juancho0202

@dlabordus dlabordus Awaiting requested review from dlabordus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plain Compare List
2 participants
@pascalwilbrink @JakobVogelsang