Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow re-opening of the same file #7

Closed
JakobVogelsang opened this issue Sep 10, 2020 · 3 comments · Fixed by #160
Closed

Allow re-opening of the same file #7

JakobVogelsang opened this issue Sep 10, 2020 · 3 comments · Fixed by #160
Labels
Difficulty: Good first issue Good for newcomers Kind: Bug Something isn't working
Milestone
Sprint 2021-03-19

Comments

@JakobVogelsang
Copy link
Collaborator

<open-scd> is currently only listening to #file-input's change event, meaning a file is not loaded if it's the same file as before.

We could either implement a "reload file" button parsing the same File object again or listen to something like #file-input's click event, checking whether the selected file has changed, and asking whether to reload if not.
@JakobVogelsang JakobVogelsang added this to the 0.1.0 milestone Sep 10, 2020
@ca-d ca-d added Kind: Enhancement New Request Difficulty: Good first issue Good for newcomers and removed To Do labels Oct 8, 2020
@ca-d ca-d added Kind: Bug Something isn't working and removed Kind: Enhancement New Request labels Nov 4, 2020
@ca-d
Copy link
Contributor

ca-d commented Nov 4, 2020

We could also reset fileInput.value = '' once loading the document is finished.

@ca-d ca-d removed this from the 0.1.0 milestone Jan 7, 2021
@ca-d
Copy link
Contributor

ca-d commented Feb 3, 2021

Which pull request resolved this issue?

@ca-d
Copy link
Contributor

ca-d commented Mar 18, 2021

This was never resolved.

@ca-d ca-d reopened this Mar 18, 2021
@ca-d ca-d added this to the Sprint 2021-03-19 milestone Mar 18, 2021
ca-d added a commit that referenced this issue Mar 18, 2021
@ca-d
fix: allow re-opening the same file again (#7)
0f8f4b5
@ca-d ca-d mentioned this issue Mar 18, 2021
Merged
JakobVogelsang pushed a commit that referenced this issue Mar 18, 2021
@ca-d
fix: allow re-opening the same file again (#7) (#160)
8b57883
JakobVogelsang pushed a commit that referenced this issue Mar 22, 2021
@ca-d @JakobVogelsang
fix: allow re-opening the same file again (#7) (#160)
d673fbf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Difficulty: Good first issue Good for newcomers Kind: Bug Something isn't working
Projects
None yet
Milestone
Sprint 2021-03-19
Development

Successfully merging a pull request may close this issue.

fix: allow re-opening the same file again openscd/open-scd
2 participants
@ca-d @JakobVogelsang