Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wizards/services): add read-only wizard on access point and ied #1109

Merged
merged 30 commits into from
Feb 23, 2023

Conversation

pascalwilbrink
Copy link
Member

@pascalwilbrink pascalwilbrink commented Dec 14, 2022

Fixes #909
Fixes #878
Fixes #887
Fixes #908
Fixes #893
Fixes #907

Signed-off-by: Pascal Wilbrink pascal.wilbrink@alliander.com

pascalwilbrink and others added 16 commits December 14, 2022 15:21
Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>

Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
…thin the IED.

The
Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Don't show the wizard pages if no content is available

Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
…y filtered out)

Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>

Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>

Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
@Sander3003
Copy link
Member

@pascalwilbrink can you finish this pull-request? I would like get in into production.

Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
@pascalwilbrink pascalwilbrink marked this pull request as ready for review February 3, 2023 13:55
Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
@JakobVogelsang JakobVogelsang changed the title Services wizard (WIP) feat(wizards/services): add read-only wizard on access point and ied Feb 7, 2023
src/editors/ied/access-point-container.ts Outdated Show resolved Hide resolved
src/editors/ied/access-point-container.ts Outdated Show resolved Hide resolved
src/editors/ied/access-point-container.ts Outdated Show resolved Hide resolved
src/foundation.ts Outdated Show resolved Hide resolved
src/foundation.ts Outdated Show resolved Hide resolved
src/wizards/service-sampled-values.ts Outdated Show resolved Hide resolved
test/integration/editors/IED.test.ts Show resolved Hide resolved
test/integration/wizards/services-wizard.test.ts Outdated Show resolved Hide resolved
test/integration/wizards/services-wizard.test.ts Outdated Show resolved Hide resolved
Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Changed the check if a wizard page should be shown to a more `complex` function. Added tests for that function

Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Copy link
Collaborator

@JakobVogelsang JakobVogelsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thx

@pascalwilbrink pascalwilbrink merged commit 81088f0 into main Feb 23, 2023
@pascalwilbrink pascalwilbrink deleted the 909_Services_Edit_Wizard branch February 23, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment