feat(menu/exportCommunication): Allow export of communication section

[danyill]

Closes #1042

This seemed straightforward to me and within my capability, so I thought I might do it.

I only belatedly realised that I had not carefully read the issue and noticed that @ca-d had self-assigned. Feel free to close my PR if this was not what you had in mind or if that's easier, I will not mind in the least 😉

I'm not very sure about the icon or the tests and the name of the extension doesn't quite fit the Menu (should the menu be wider?)

Incidentally, I'm interested in this because I'd like to define (at some point) a custom file format for the communication section to function as an interface for confirming IPAM and to enable building network switch configuration with Communication section information on VLANs and with MAC address filtering for SV traffic. At some stage, I'll raise a separate issue for that. What is missing is "who needs" the GOOSE/SMV traffic.

[danyill]

@ca-d suggested making this a conformant SCL file by including the SCL root note and the Header element as well. I will add these.

[danyill]

@ca-d suggested making this a conformant SCL file by including the SCL root note and the Header element as well. I will add these.

I have done these, I hope - I will be grateful for a review and happy to make improvements.
I will also want to add some documentation for this plugin for the Help function.

[ca-d]

@ca-d suggested ...

I have done these

Thank you, @danyill - great work overall! Regarding the Help, I think it'll be useful to update the wiki, but I'd really like to fix the help viewer (internal links currently do not work) before updating the content again. Currently the built in help viewer is hardly usable to me.

My current favored solution for fixing this bug:

1. Introduce a build step which compiles the markdown to static HTML files into the distribution directory.
2. Get rid of the markdown renderer runtime dependency.
3. Render the static html help statically into an iframe in an editor type plugin using import.meta.url to construct the iframe's original src attribute.
4. ???
5. Profit!

[ca-d]

Not all of the comments need to be attended to in this pull request (especially not help viewer bugfixes and a more robust foundation save blob function), but let's discuss them and make extra issues for the ones we want to implement before merging this!

[danyill]

👍 Thank you both for these review comments, I hope to look at these over the next few days

[danyill]

Regarding the Help, I think it'll be useful to update the wiki, but I'd really like to fix

I have logged #1057

[danyill]

I did have before but removed as per review comments. I thought this would at least test the plugin functions without an exception. I would be pleased to receive some help.

…

On Thu, 17 Nov 2022, 20:44 cad, ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In test/integration/menu/ExportCommunication.test.ts <#1044 (comment)>: > + + parent = await fixture(html` + <mock-wizard-editor + ><export-communication></export-communication + ></mock-wizard-editor> + `); + + element = <ExportCommunication>( + parent.querySelector('export-communication')! + ); + + element.doc = doc; + element.docName = 'CommunicationTest.scd'; + element.run(); + await parent.requestUpdate(); + }); I don't get this test file, did you have some tests in here before, or did you still intend to add some? If you want help coming up with tests, I'd be happy to think of a couple together. — Reply to this email directly, view it on GitHub <#1044 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFEXXZAKSCE3AWWMSAOUJTWIXO4BANCNFSM6AAAAAARGEAI3A> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[ca-d]

LGTM

[danyill]

Thank you ca-d for reviewing this and for providing the tests