Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make LGOS and LSVS accessible in subscription editors #1037

Closed
danyill opened this issue Oct 10, 2022 · 6 comments · Fixed by #1082 or #1141
Closed

Make LGOS and LSVS accessible in subscription editors #1037

danyill opened this issue Oct 10, 2022 · 6 comments · Fixed by #1082 or #1141
Assignees
Labels

Comments

@danyill
Copy link
Collaborator

danyill commented Oct 10, 2022

Is your feature request related to a problem? Please describe.

When #942 is complete, supervision of subscriptions will be provided.
But it will not be visible to the user.

As a user, I care about this because I want to know:

  • Where is this subscription supervised?
  • When browsing the SCL object model online, which LSVS or LGOS logical node is associated with the communications of this FCDA or Control Element.

Describe the solution you'd like

I would like to see the path to the LN and the LN name and a small icon to indicate supervision, perhaps monitor_heart

Perhaps something like one of these for the later binding plugin:

image

Perhaps only the LN information could be shown with the fully qualified path being a tooltip.

Another option might be to show only the monitor_heart icon with the tooltip being the path and the LGOS name which would reduce clutter. This would mean "this subscription is supervised" and the user would need to hover to see the detail. The icon could be a button which opened the Logical Node editor for the user to access additional details.

In the Subscriber(GOOSE) and Subscriber(SMV) plugins, perhaps it could be on the right.

image

image

@danyill danyill added the Kind: Enhancement New Request label Oct 10, 2022
@danyill danyill changed the title Make LGOS and LSVS visible against associated FCDA Elements or C Make LGOS and LSVS visible Oct 10, 2022
@danyill danyill changed the title Make LGOS and LSVS visible Make LGOS and LSVS accessible in subscription editors Oct 10, 2022
@JakobVogelsang
Copy link
Collaborator

I like the proposal to put it as a meta icon into the mwc-list-item. I think this will not additionally clutter the list item as it is already. Furthermore, I also would propose to have a tooltip with the identity string of the logical node instance LN. I like the icon you have selected monitor_heart.

@JakobVogelsang
Copy link
Collaborator

As discussed in our last refinement session we want to add a indicator for subscription supervision:

Requirements
in case there is a subscription supervision for a GOOSE or SampledValue stream

  • add meta icon to every list item that indicates a subscribed message/data
  • use heart monitor from google fonts
  • add a tooltip to this meta icon having the identity of the supervision logical node e.g. IED2>>LD0> LGOS 1 or IED2>>LD0> LSVS 1

Mockup
grafik

danyill added a commit to danyill/open-scd that referenced this issue Oct 30, 2022
@danyill danyill self-assigned this Oct 30, 2022
danyill added a commit to danyill/open-scd that referenced this issue Nov 3, 2022
@danyill danyill linked a pull request Nov 4, 2022 that will close this issue
danyill added a commit to danyill/open-scd that referenced this issue Nov 16, 2022
@danyill danyill linked a pull request Nov 16, 2022 that will close this issue
@ca-d
Copy link
Contributor

ca-d commented Nov 17, 2022

  • add a tooltip to this meta icon having the identity of the supervision logical node e.g. IED2>>LD0> LGOS 1 or IED2>>LD0> LSVS 1

Do you think it may be possible to add that information to the list item text instead (and then maybe have a tooltip for the whole list item as in the current log), or go twoline and put the monitoring IED in the secondary slot? I'd love to have the information more accessible than just in a tooltip.

@danyill
Copy link
Collaborator Author

danyill commented Nov 17, 2022 via email

@danyill
Copy link
Collaborator Author

danyill commented Nov 19, 2022

Do you think it may be possible to add that information to the list item text instead (and then maybe have a tooltip for the whole list item as in the current log), or go twoline and put the monitoring IED in the secondary slot? I'd love to have the information more accessible than just in a tooltip.

There may also be circumstances under which it would be nice to filter on the supervision node to allow answering the question, "What is this supervision node for?" or more likely "Where is this GOOSE/SV message supervised within receiving devices?"

danyill added a commit that referenced this issue Nov 23, 2022
@danyill
Copy link
Collaborator Author

danyill commented Nov 23, 2022

Re-opening for further discussion on #1037 (comment)

@danyill danyill reopened this Nov 23, 2022
danyill added a commit to danyill/open-scd that referenced this issue Jan 24, 2023
* Remove clutter in later binding (closes openscd#1024)
* Add subscription information (closes openscd#1037)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment