fixes: Services section tooltip seems incorrect (#1252)

* fix: tooltip for ied-container's settings icon * fix: update tooltip text to account for ports * test: fixing ied-container snapshot * chore: adding missing german translations * Update src/translations/en.ts Signed-off-by: Sander Jansen <sander.jansen@alliander.com> Co-authored-by: danyill <danyill@users.noreply.github.com> --------- Co-authored-by: Sander Jansen <Sander3003@users.noreply.github.com> Co-authored-by: danyill <danyill@users.noreply.github.com>
openscd · May 11, 2023 · f113180 · f113180
1 parent 04d351f
commit f113180
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 4 deletions.
diff --git a/src/editors/ied/access-point-container.ts b/src/editors/ied/access-point-container.ts
@@ -46,7 +46,7 @@ export class AccessPointContainer extends Container {
       return html``;
     }
 
-    return html` <abbr slot="action" title="${translate('settings')}">
+    return html` <abbr slot="action" title="${translate('iededitor.settings')}">
       <mwc-icon-button
         icon="settings"
         @click=${() => this.openSettingsWizard(services)}

diff --git a/src/editors/ied/ied-container.ts b/src/editors/ied/ied-container.ts
@@ -40,7 +40,7 @@ export class IedContainer extends Container {
       return html``;
     }
 
-    return html` <abbr slot="action" title="${translate('settings')}">
+    return html` <abbr slot="action" title="${translate('iededitor.settings')}">
       <mwc-icon-button
         icon="settings"
         @click=${() => this.openSettingsWizard(services)}

diff --git a/src/translations/de.ts b/src/translations/de.ts
@@ -222,9 +222,10 @@ export const de: Translations = {
   },
   iededitor: {
     iedSelector: 'IED auswählen',
-    lnFilter: '???',
+    lnFilter: 'Filter für logische Knoten',
     missing: 'Kein IED vorhanden',
     toggleChildElements: 'Kindelemente umschalten',
+    settings: 'Services für IED or AccessPoint',
     wizard: {
       daTitle: 'DA Informationen anzeigen',
       doTitle: 'DO Informationen anzeigen',

diff --git a/src/translations/en.ts b/src/translations/en.ts
@@ -222,6 +222,7 @@ export const en = {
     lnFilter: 'Logical Node Filter',
     missing: 'No IED',
     toggleChildElements: 'Toggle child elements',
+    settings: 'Show Services the IED/AccessPoint provides',
     wizard: {
       daTitle: 'Show DA Info',
       doTitle: 'Show DO Info',

diff --git a/test/unit/editors/ied/__snapshots__/ied-container.test.snap.js b/test/unit/editors/ied/__snapshots__/ied-container.test.snap.js
@@ -22,7 +22,7 @@ snapshots["ied-container looks like the latest snapshot"] =
   </abbr>
   <abbr
     slot="action"
-    title="[settings]"
+    title="[iededitor.settings]"
   >
     <mwc-icon-button icon="settings">
     </mwc-icon-button>