Apcs documentation expansion

[HelenCEBM]

No description provided.

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Pages

Latest commit:	2945cfc
Status:	✅  Deploy successful!
Preview URL:	https://92a835e6.opensafely-docs.pages.dev

View logs

[StevenMaude]

I looked at the Cloudflare Pages failure here because I wondered why that failed, but the GitHub Actions check (should be the same) passed.

When the site was being built, it couldn't find the images/create-repository-owner.png for getting_started.md which is unrelated to the changes here. Probably due to the GitHub/Fastly outages earlier.

[HelenCEBM]

@StevenMaude thanks - it's still failing, do you think that's a problem?

[StevenMaude]

So this is my mistake at making a quick assumption :. I got confused because of the Fastly outage last week and assumed there was some weirdness there 😳

Short answer: the fix is to rebase this branch on the main branch, so that it's up-to-date.

Slightly longer answer: the reason for the failure on GitHub Actions, but passing on Cloudflare Pages is a little convoluted. I'll try and explain, because it took me a few minutes to figure out:

1. @HelenCEBM started working on this branch back at the start of the March.
2. This was before we checked with mkdocs build --strict which fails on any warnings. A couple of issues also got fixed as a result of using --strict including a broken image link in the Markdown that causes the failure here. These fixes are now in the master branch.
3. Cloudflare Pages checks out the most recent commit of this branch. The most recent commit of this branch still contains the broken link. If you checkout this pull request branch, it still fails mkdocs build --strict.
4. The default GitHub Actions checkout action behaviour is that it creates a merge commit of the pull request branch and the branch being merged. (I realised this on looking at the Actions run logs and not being able to find the commit being tested in the repository.) For the merge commit, the docs don't have this broken link because it is fixed in the main branch.

Incidentally, not sure whether we can configure Cloudflare Pages to build a merge of a pull request, and if that is the right thing to do.