adding gradle and groovy auto detection #4561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding autodetect for groovy and gradle, adding 2 seperact auto detection classes to allow for repositories to have different styles for gradle build files and groovy tests. These auto detection classes utilize the java auto detection
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
rewrite-gradle/src/test/java/org/openrewrite/gradle/style/AutodetectTest.java
Show resolved
Hide resolved
rewrite-gradle/src/test/java/org/openrewrite/gradle/style/AutodetectTest.java
Outdated
Show resolved
Hide resolved
rewrite-groovy/src/test/java/org/openrewrite/groovy/style/AutodetectTest.java
Show resolved
Hide resolved
rewrite-groovy/src/test/java/org/openrewrite/groovy/style/AutodetectTest.java
Outdated
Show resolved
Hide resolved
…detectTest.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…detectTest.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
sambsnyd
reviewed
Oct 8, 2024
| ); | ||
| var detector = Autodetect.detector(); | ||
| parse.forEach(detector::sample); | ||
| var styles = detector.build(); |
There was a problem hiding this comment.
Is the type of styles org.openrewrite.java.style.Autodetect or org.openrewrite.gradle.style.Autodetect ? 🙂
Might influence whether your other PRs work as intended or not.
There was a problem hiding this comment.
you are 100% correct, I have pushed an update which will fix this issue
sambsnyd
approved these changes
Oct 8, 2024
| @@ -65,8 +65,7 @@ public static class Detector { | |||
| private final FindLineFormatJavaVisitor findLineFormat = new FindLineFormatJavaVisitor(); | |||
|
|
|||
| public void sample(SourceFile cu) { | |||
| // only sample Java sources (extending languages need their own auto-detection) | |||
| if (cu instanceof J.CompilationUnit) { | |||
| if (cu instanceof JavaSourceFile) { | |||
There was a problem hiding this comment.
@sambsnyd It seems to me that we shouldn't have to change this now. What am I missing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the autodetect class to pick up styles from the gradle files
Previously no style would be detected for groovy files, this is because we weren't parsing the block element within lambdas in method declarations