Added Profile dependency migration #4310
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profile dependency migration
What's changed?
Dependencies can now be migrated within the profile section whether there are inside of a dependencyManagement section or declared as normal dependencies. That's why profile dependency validations are now added to the MavenVisitor class.
Example:
Before:
After:
What's your motivation?
A question was posted on slack by @ErhardSiegl referring the not migrating dependencies inside profiles.
Regarding this problem I took the initiative and implemented it.
Have you considered any alternatives or workarounds?
While working on this topic, I noticed a missing recipe for plugins and profiles. While it is possible to add profiles or change plugin dependencies, there are no options to change a dependency groupId, artifactId, or version within plugins or profiles separately. Just a heads up, maybe consider implementing a recipe to be able to change this in the future.