Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not perform JUnit4to5Migration where TestNG is used #592

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Do not perform JUnit4to5Migration where TestNG is used #592

merged 2 commits into from
Sep 5, 2024

Conversation

Laurens-W
Copy link
Contributor

@Laurens-W Laurens-W commented Sep 5, 2024 •
edited by timtebeek
Loading

What's changed?

Precondition added to JUnit4to5Migration that checks whether testNG is used

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

@timtebeek

Additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@Laurens-W Laurens-W added the bug Something isn't working label Sep 5, 2024
@Laurens-W Laurens-W requested a review from timtebeek September 5, 2024 08:12
@Laurens-W Laurens-W self-assigned this Sep 5, 2024
@timtebeek timtebeek marked this pull request as ready for review September 5, 2024 08:19
@timtebeek timtebeek changed the title Do not perform JUnit4to5Migration when testNG is used Do not perform JUnit4to5Migration when TestNG is used Sep 5, 2024
@timtebeek timtebeek changed the title Do not perform JUnit4to5Migration when TestNG is used Do not perform JUnit4to5Migration where TestNG is used Sep 5, 2024
@Laurens-W @timtebeek
Update src/main/resources/META-INF/rewrite/junit5.yml
ade2767 
Co-authored-by: Tim te Beek <tim@moderne.io>
@Laurens-W Laurens-W requested a review from timtebeek September 5, 2024 08:58
@timtebeek timtebeek merged commit fd664b2 into main Sep 5, 2024
2 checks passed
@timtebeek timtebeek deleted the no-junit-when-testng-found branch September 5, 2024 09:17
@timtebeek timtebeek mentioned this pull request Sep 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timtebeek timtebeek Awaiting requested review from timtebeek

Assignees

@Laurens-W Laurens-W

Labels
bug Something isn't working
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Laurens-W @timtebeek