-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JMockit to Mockito Recipe - Rewrite JMockit Mocked Variable to Mockito statements #481
JMockit to Mockito Recipe - Rewrite JMockit Mocked Variable to Mockito statements #481
Conversation
Great addition right away @zenghu1chen ; thanks a lot! I imagine @tinder-dthomson would also be interested in seeing this, given his involvement with the JMockit to Mockito migration recipes so far. I'll do a more thorough review in the days ahead. :) |
src/test/java/org/openrewrite/java/testing/jmockit/JMockitMockedVariableToMockitoTest.java
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/testing/jmockit/JMockitMockedVariableToMockitoTest.java
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved from my side already; I'll give @tinder-dthomson a day or so to weigh in too just in case, and otherwise merge as is. Thanks a lot @zenghu1chen !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad to see this contribution! Definitely something that the existing recipe did not yet handle, well done!
What's changed?
Improvements:
void someMethod(@Mocked Object o)
)What's your motivation?
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
Any additional context
Checklist