Prevent incorrect change from IsEqualToBoolean

openrewrite · Jul 10, 2024 · a79dc45 · a79dc45
1 parent dc5e689
commit a79dc45
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 4 deletions.
diff --git a/src/main/java/org/openrewrite/java/testing/assertj/IsEqualToBoolean.java b/src/main/java/org/openrewrite/java/testing/assertj/IsEqualToBoolean.java
@@ -60,8 +60,10 @@ public J.MethodInvocation visitMethodInvocation(J.MethodInvocation method, Execu
                     String methodName;
                     if (J.Literal.isLiteralValue(mi.getArguments().get(0), true)) {
                         methodName = "isTrue";
-                    } else {
+                    } else if (J.Literal.isLiteralValue(mi.getArguments().get(0), false)) {
                         methodName = "isFalse";
+                    } else {
+                        return mi;
                     }
                     Method isBooleanMethod = mi.getMethodType().withName(methodName);
                     return mi.withName(mi.getName().withSimpleName(methodName).withType(isBooleanMethod))

diff --git a/src/test/java/org/openrewrite/java/testing/assertj/IsEqualToBooleanTest.java b/src/test/java/org/openrewrite/java/testing/assertj/IsEqualToBooleanTest.java
@@ -72,11 +72,28 @@ void test() {
                   }
               }
               """,
-              """
+            """
+            import static org.assertj.core.api.Assertions.assertThat;
+            class Test {
+                void test() {
+                    assertThat(false).isFalse();
+                }
+            }
+            """
+          )
+        );
+    }
+
+    @Test
+    void noChangeOnVariable() {
+        rewriteRun(
+          // language=java
+          java(
+            """
               import static org.assertj.core.api.Assertions.assertThat;
               class Test {
-                  void test() {
-                      assertThat(false).isFalse();
+                  void test(boolean b) {
+                      assertThat(false).isEqualTo(b);
                   }
               }
               """