ReplaceDuplicateStringLiterals throws NPE from 1.19.0+ #384

[adambir]

• Fix ReplaceDuplicateStringLiterals throws java.lang.NullPointerException on version 1.19.0 #384

What's changed?

Added a test for issue #384 on the ReplaceDuplicateStringLiterals recipe.

What's your motivation?

Allow reproduction of the bug

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

[timtebeek]

Thanks for the clear report here @adambir ! Turns out my IDE warned about the same potential NPE that you were seeing. Fixed now by adjusting the condition just above.

[Bananeweizen]

@timtebeek Would you mind checking this fix again? The previous logic was effectively "! instanceof String", and the negation is lost now. While I can't really judge the overall condition, the code after the if-condition supports my claim: In line 236 is an explicit getValue().toString() (indicating this is not instanceof String yet). Compare that to line 242, where getValue() is taken directly after checking instanceof String.

[timtebeek]

Keen eye there! I've restored the original conditiona and added another to indeed handle these cases correctly, thanks!