Autoformat/spacevisitor

[nielsdebruin]

What's changed?

Added progress on space visitor. Based on

• Python Autoformatter: Spaces #97

What's your motivation?

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

[knutwannheden]

Nice!

Let's merge this and fix any remaining issues in follow-up commits. From what I saw we need some tests for trailing comma syntax and we also need to make sure to always use list_map() rather than list comprehensions when updating the LST model.

[knutwannheden]

Can we add one more test for the within.braces style? The visitor implements formatting for this, but I don't see any actual test for it.

[knutwannheden]

I also believe that the formatting style for within.braces probably should also apply to sets, set comprehensions, and dictionary comprehensions. These cases are probably not covered yet by the formatter. Similarly, the within.brackets should also apply to list comprehensions.

[knutwannheden]

One more case which we should at least have tests for (didn't check if the visitor already covers it or not) is type hints, so that we can check that witin.brackets correctly formats type hints like Union[str, int].

[github-actions]

Some suggestions could not be made:

• rewrite-python-remote/src/main/java/org/openrewrite/python/remote/Extensions.java
  • lines 18-20
  • lines 33-32
• rewrite-python-remote/src/main/java/org/openrewrite/python/remote/PythonReceiver.java
  • lines 31-34
  • lines 2508-2511
• rewrite-python-remote/src/main/java/org/openrewrite/python/remote/PythonSender.java
  • lines 29-31
  • lines 1187-1190
• rewrite-python-remote/src/main/java/org/openrewrite/python/remote/PythonValidator.java
  • lines 26-30
• rewrite-python/src/main/java/org/openrewrite/python/tree/Py.java
  • lines 375-374
• rewrite-python/src/test/java/org/openrewrite/python/tree/CollectionTest.java
  • lines 40-40