v1 of style Autodetect #120
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+81
to
+84
| private int countSpaces(String s) { | ||
| int withoutSpaces = s.replaceAll(" ", "").length(); | ||
| return s.length() - withoutSpaces; | ||
| } |
There was a problem hiding this comment.
Even though this implementation currently only supports very simple detection, I would already now align it with the implementation we have for Java (see FindIndentJavaVisitor and IndentStatistics classes), as we will soon require that anyway to detect more complex cases (e.g. tabs or mixed spaces and tabs). Also note that we should try to avoid using methods like String#replaceAll() which behind the scenes will instantiate a regex pattern, as the allocation cost will put the GC under a lot of pressure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Adding
Autodetectwith basic implementation which identifies just one parameter for now - the indent size.Not plugging in this implementation anywhere yet. I think that could be done when it's more complete.
What's your motivation?