Fix and extra tests for literals #115
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsdebruin
force-pushed
the
fix/stringliteral
branch
from
8dab859 to
c2b9cdf
Compare
Comment on lines
706
to
711
| def my_function(): | ||
| a = """ | ||
| This is a string that | ||
| should align with the function body. | ||
| """ | ||
| return None |
There was a problem hiding this comment.
Actually, if you test this with PyCharm you will notice that it doesn't indent the contents of the string literal. This only happens when you remove the assignment, which identifies the string literal as a doc comment.
This is one area where Java text blocks behave differently. Their content is always stripped of all common leading indentation. As a result the text blocks can be indented without the string's runtime value changing. I think this is an extremely useful feature which I miss in Python. But that explains why the formatter must only indent the contents of doc comment string literals.
There was a problem hiding this comment.
I modified the test
nielsdebruin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
The
TabsAndIndentsVisitorcannot correctly handle literals that are not assigned to anything. Currently, this PR add tests to illustrate this behavior.What's your motivation?
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
Any additional context
Checklist