Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten call to get enclosing method declaration #562

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Shorten call to get enclosing method declaration #562

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/openrewrite/java/migrate/javax/HttpSessionInvalidate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public TreeVisitor<?, ExecutionContext> getVisitor() {
public J.MethodInvocation visitMethodInvocation(J.MethodInvocation method, ExecutionContext ctx) {
if (invalidateMethodMatcher.matches(method)) {
// Get index of param for HttpServletRequest, from the encapsulating method declaration TODO: would like to make this cleaner...
J.MethodDeclaration parentMethod = getCursor().dropParentUntil(parent -> parent instanceof J.MethodDeclaration).getValue();
J.MethodDeclaration parentMethod = getCursor().firstEnclosing(J.MethodDeclaration.class);
Integer servletReqParamIndex = getServletRequestIndex(parentMethod);

// Failed to find HttpServletRequest from parent MethodDeclaration
Expand Down