Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StringFormatted should not leave trailing whitespace after replacement #556

Merged
merged 7 commits into from
Sep 15, 2024
Merged

StringFormatted should not leave trailing whitespace after replacement #556

merged 7 commits into from
Sep 15, 2024

Conversation

BramliAK
Copy link
Contributor

@BramliAK BramliAK commented Sep 15, 2024 •
edited by timtebeek
Loading

What's changed?

I updated the StringFormattedVisitor class to remove return line for the first argument

What's your motivation?

Integrating openRewitre team

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@timtebeek timtebeek changed the title Issue 453 string formatted recipe StringFormatted should not leave trailing whitespace after replacement Sep 15, 2024
@timtebeek timtebeek added the bug Something isn't working label Sep 15, 2024
@timtebeek timtebeek self-requested a review September 15, 2024 20:54
This was linked to issues Sep 15, 2024
Minor issue with StringFormatted recipe #453
Closed
UseTextBlocks creating unnecessary trailing escape #555
Closed
@timtebeek timtebeek removed a link to an issue Sep 15, 2024
UseTextBlocks creating unnecessary trailing escape #555
Closed
@timtebeek
Copy link
Contributor

Thanks for the fix here @BramliAK ! I've pushed up a few quick polishing commits; good to see this resolved!

@timtebeek timtebeek merged commit b5ab237 into openrewrite:main Sep 15, 2024
2 checks passed
@coderustic coderustic mentioned this pull request Oct 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timtebeek timtebeek Awaiting requested review from timtebeek

Assignees

@BramliAK BramliAK

Labels
bug Something isn't working
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minor issue with StringFormatted recipe
2 participants
@BramliAK @timtebeek