Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: UseEnumSetOf should ignore array and varargs parameters #518

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

mbruggmann
Copy link
Contributor

EnumSet doesn't have the equivalent of Set.of(arr[]). For now, let's just skip those cases and bail out.

Fixes #516.

EnumSet doesn't have the equivalent of `Set.of(arr[])`. For now,
let's just skip those cases and bail out.
@timtebeek timtebeek self-requested a review July 26, 2024 13:35
@timtebeek timtebeek added the bug Something isn't working label Jul 26, 2024
@mbruggmann mbruggmann marked this pull request as ready for review July 26, 2024 13:39
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see, thanks a lot! Nice to have this quick turn around on a report & fix.

@mbruggmann
Copy link
Contributor Author

Likewise, thanks @timtebeek!

@timtebeek timtebeek merged commit bc0d2eb into openrewrite:main Jul 26, 2024
2 checks passed
@mbruggmann mbruggmann deleted the enumset-varargs branch July 26, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

UseEnumSetOf rewrite breaks for varargs parameter
2 participants