Skip to content

Commit

Permalink
Apply OpenRewrite best practices to silence review bot
Browse files Browse the repository at this point in the history
  • Loading branch information
@timtebeek
timtebeek committed Jul 29, 2024
1 parent 61ed4bc commit 6ba16cc
Showing 1 changed file with 74 additions and 72 deletions.
146 changes: 74 additions & 72 deletions ...st/java/org/openrewrite/java/migrate/maven/UpdateMavenProjectPropertyJavaVersionTest.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -38,42 +38,42 @@ void basic() {
rewriteRun(
//language=xml
pomXml(
"""
<project>
<groupId>com.example</groupId>
<artifactId>foo</artifactId>
<version>1.0.0</version>
<modelVersion>4.0</modelVersion>
<properties>
<java.version>11</java.version>
<jdk.version>11</jdk.version>
<javaVersion>11</javaVersion>
<jdkVersion>11</jdkVersion>
<maven.compiler.source>11</maven.compiler.source>
<maven.compiler.target>11</maven.compiler.target>
<maven.compiler.release>11</maven.compiler.release>
<release.version>11</release.version>
</properties>
</project>
""",
"""
<project>
<groupId>com.example</groupId>
<artifactId>foo</artifactId>
<version>1.0.0</version>
<modelVersion>4.0</modelVersion>
<properties>
<java.version>17</java.version>
<jdk.version>17</jdk.version>
<javaVersion>17</javaVersion>
<jdkVersion>17</jdkVersion>
<maven.compiler.source>17</maven.compiler.source>
<maven.compiler.target>17</maven.compiler.target>
<maven.compiler.release>17</maven.compiler.release>
<release.version>17</release.version>
</properties>
</project>
""")
<project>
<groupId>com.example</groupId>
<artifactId>foo</artifactId>
<version>1.0.0</version>
<modelVersion>4.0</modelVersion>
<properties>
<java.version>11</java.version>
<jdk.version>11</jdk.version>
<javaVersion>11</javaVersion>
<jdkVersion>11</jdkVersion>
<maven.compiler.source>11</maven.compiler.source>
<maven.compiler.target>11</maven.compiler.target>
<maven.compiler.release>11</maven.compiler.release>
<release.version>11</release.version>
</properties>
</project>
""",
"""
<project>
<groupId>com.example</groupId>
<artifactId>foo</artifactId>
<version>1.0.0</version>
<modelVersion>4.0</modelVersion>
<properties>
<java.version>17</java.version>
<jdk.version>17</jdk.version>
<javaVersion>17</javaVersion>
<jdkVersion>17</jdkVersion>
<maven.compiler.source>17</maven.compiler.source>
<maven.compiler.target>17</maven.compiler.target>
<maven.compiler.release>17</maven.compiler.release>
<release.version>17</release.version>
</properties>
</project>
""")
);
}

Expand All @@ -82,24 +82,24 @@ void bringsDownExplicitlyUsedPropertyFromRemoteParent() {
rewriteRun(
//language=xml
pomXml(
"""
<project>
<groupId>com.example</groupId>
<artifactId>example-parent</artifactId>
<version>1.0.0</version>
<modelVersion>4.0</modelVersion>
<properties>
<java.version>11</java.version>
<jdk.version>11</jdk.version>
<javaVersion>11</javaVersion>
<jdkVersion>11</jdkVersion>
<maven.compiler.source>11</maven.compiler.source>
<maven.compiler.target>11</maven.compiler.target>
<maven.compiler.release>11</maven.compiler.release>
<release.version>11</release.version>
</properties>
</project>
""",
"""
<project>
<groupId>com.example</groupId>
<artifactId>example-parent</artifactId>
<version>1.0.0</version>
<modelVersion>4.0</modelVersion>
<properties>
<java.version>11</java.version>
<jdk.version>11</jdk.version>
<javaVersion>11</javaVersion>
<jdkVersion>11</jdkVersion>
<maven.compiler.source>11</maven.compiler.source>
<maven.compiler.target>11</maven.compiler.target>
<maven.compiler.release>11</maven.compiler.release>
<release.version>11</release.version>
</properties>
</project>
""",
SourceSpec::skip),
mavenProject("example-child",
//language=xml
Expand Down Expand Up @@ -130,7 +130,7 @@ void bringsDownExplicitlyUsedPropertyFromRemoteParent() {
</build>
</project>
""",
"""
"""
<project>
<parent>
<groupId>com.example</groupId>
Expand Down Expand Up @@ -169,25 +169,27 @@ void bringsDownExplicitlyUsedPropertyFromRemoteParent() {
void addReleaseIfNoOtherChangeIsMade() {
rewriteRun(
//language=xml
pomXml("""
<project>
<groupId>com.example</groupId>
<artifactId>example-child</artifactId>
<version>1.0.0</version>
<modelVersion>4.0</modelVersion>
</project>
""",
pomXml(
"""
<project>
<groupId>com.example</groupId>
<artifactId>example-child</artifactId>
<version>1.0.0</version>
<modelVersion>4.0</modelVersion>
<properties>
<maven.compiler.release>17</maven.compiler.release>
</properties>
</project>
""")
<project>
<groupId>com.example</groupId>
<artifactId>example-child</artifactId>
<version>1.0.0</version>
<modelVersion>4.0</modelVersion>
</project>
""",
"""
<project>
<groupId>com.example</groupId>
<artifactId>example-child</artifactId>
<version>1.0.0</version>
<modelVersion>4.0</modelVersion>
<properties>
<maven.compiler.release>17</maven.compiler.release>
</properties>
</project>
"""
)
);
}
}

0 comments on commit 6ba16cc

Please sign in to comment.