Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning org.apache.commons:commons-io has been relocated #223

Closed
Postremus opened this issue Oct 12, 2021 · 3 comments
Closed

Warning org.apache.commons:commons-io has been relocated #223

Postremus opened this issue Oct 12, 2021 · 3 comments
Assignees

Comments

@Postremus
Copy link
Contributor

When I run recipes on my project using mvn rewrite:run, I get following warning from the maven plugin.

The recipes are executed, just an annoying warning.

[INFO] --- rewrite-maven-plugin:4.14.0-SNAPSHOT:run (default-cli) @ project ---
[WARNING] The artifact org.apache.commons:commons-io:jar:1.3.2 has been relocated to commons-io:commons-io:jar:1.3.2: https://issues.sonatype.org/browse/MVNCENTRAL-244
@aegershman aegershman self-assigned this Oct 12, 2021
aegershman added a commit to openrewrite/rewrite-migrate-java that referenced this issue Oct 12, 2021
aegershman added a commit to openrewrite/rewrite that referenced this issue Oct 12, 2021
@aegershman
Copy link
Contributor

@Postremus Thanks to you logging this, we now know that org.apache.commons:commons-io has been relocated to commons-io:commons-io, and there's now a recipe to handle it: openrewrite/rewrite-migrate-java@6829a6f -- I went ahead and changed our upstream rewrite core to ensure it's using the relocated package, too: openrewrite/rewrite@1178b36

Could you try this out again when you get an opportunity using the latest refreshed snapshots? I'll be honest, I wasn't able to duplicate seeing the warning message you did locally. Nonetheless, our latest snapshot references should no longer result in having references to org.apache.commons:commons-io. If the warning still appears, could you share more details on your pom of which dependencies the rewrite plugin is using + the recipes you have wired up?

Thanks again @Postremus 👍

@Postremus
Copy link
Contributor Author

@aegershman

The warning is not printed anymore, after rebuilding the maven-rewrite-plugin locally, and updating my recipes to use rewrite 7.16.0-SNAPSHOT

I just remembered reading about the cause of this. This is related to maven 3.8.3, which I use locally.
The relocation message was never displayed previously with maven 3.8.1, which is the current version used for mvnw.

The related Maven PR:
apache/maven#544

I updated mvnw in PR #224

@aegershman
Copy link
Contributor

Merged; right on. I'll go ahead and close this issue, but feel free to @ me if you think it should remain open, or feel free to open any other issues. Thanks again @Postremus good finds, I appreciate it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants