Switch to a list of warnings to have the full details

openrewrite · Feb 4, 2025 · ace19f6 · ace19f6
1 parent cce8e3c
commit ace19f6
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 14 deletions.
diff --git a/src/main/java/org/openrewrite/maven/AbstractRewriteDryRunMojo.java b/src/main/java/org/openrewrite/maven/AbstractRewriteDryRunMojo.java
@@ -28,6 +28,8 @@
 import java.nio.file.Path;
 import java.nio.file.Paths;
 import java.time.Duration;
+import java.util.ArrayList;
+import java.util.List;
 import java.util.concurrent.atomic.AtomicReference;
 import java.util.stream.Stream;
 
@@ -67,8 +69,8 @@ public void execute() throws MojoExecutionException, MojoFailureException {
             return;
         }
 
-        AtomicReference<@Nullable Throwable> throwable = new AtomicReference<>();
-        ExecutionContext ctx = executionContext(throwable);
+        List<Throwable> throwables = new ArrayList<>();
+        ExecutionContext ctx = executionContext(throwables);
 
         ResultsContainer results = listResults(ctx);
 
@@ -77,8 +79,8 @@ public void execute() throws MojoExecutionException, MojoFailureException {
             getLog().error("The recipe produced an error. Please report this to the recipe author.");
             throw firstException;
         }
-        if (throwable.get() != null) {
-            getLog().warn("The recipe produced a warning. Please report this to the recipe author.", throwable.get());
+        if (!throwables.isEmpty()) {
+            getLog().warn("The recipe produced " + throwables.size() + " warning(s). Please report this to the recipe author.", throwables.get(0));
         }
 
         if (results.isNotEmpty()) {

diff --git a/src/main/java/org/openrewrite/maven/AbstractRewriteMojo.java b/src/main/java/org/openrewrite/maven/AbstractRewriteMojo.java
@@ -126,12 +126,8 @@ protected Environment environment(@Nullable ClassLoader recipeClassLoader) throw
         return env.build();
     }
 
-    protected ExecutionContext executionContext(AtomicReference<@Nullable Throwable> throwable) {
-        return new InMemoryExecutionContext(t -> {
-            if (throwable.get() == null) {
-                throwable.set(t);
-            }
-        });
+    protected ExecutionContext executionContext(List<Throwable> throwables) {
+        return new InMemoryExecutionContext(throwables::add);
     }
 
     protected Path getBuildRoot() {

diff --git a/src/main/java/org/openrewrite/maven/AbstractRewriteRunMojo.java b/src/main/java/org/openrewrite/maven/AbstractRewriteRunMojo.java
@@ -32,6 +32,7 @@
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.time.Duration;
+import java.util.ArrayList;
 import java.util.List;
 import java.util.concurrent.atomic.AtomicReference;
 
@@ -61,8 +62,8 @@ public void execute() throws MojoExecutionException, MojoFailureException {
             return;
         }
 
-        AtomicReference<@Nullable Throwable> throwable = new AtomicReference<>();
-        ExecutionContext ctx = executionContext(throwable);
+        List<Throwable> throwables = new ArrayList<>();
+        ExecutionContext ctx = executionContext(throwables);
 
         ResultsContainer results = listResults(ctx);
 
@@ -71,8 +72,8 @@ public void execute() throws MojoExecutionException, MojoFailureException {
             getLog().error("The recipe produced an error. Please report this to the recipe author.");
             throw firstException;
         }
-        if (throwable.get() != null) {
-            getLog().warn("The recipe produced a warning. Please report this to the recipe author.", throwable.get());
+        if (!throwables.isEmpty()) {
+            getLog().warn("The recipe produced " + throwables.size() + " warning(s). Please report this to the recipe author.", throwables.get(0));
         }
 
         if (results.isNotEmpty()) {