Add support for variables in RemoveWas2LibertyNonPortableJndiLookup recipe

[rlsanders4]

What's changed?

The RemoveWas2LibertyNonPortableJndiLookup recipe is intended to remove Hashtable.put() method invocations using the following WebSphere properties:

java.naming.factory.initial
java.naming.provider.url

Currently, this only works if these properties are specified in the method invocation as string literals. With this PR adds support for the case in which these parameters are passed into the method invocation as variables.

What's your motivation?

The RemoveWas2LibertyNonPortableJndiLookup recipe will only remove method invocations using properties that are specified as string literals, but it would fail to remove method invocation using properties specifed using variables.

For example, this method invocation will be removed:

Hashtable ht = new Hashtable();
ht.put("java.naming.factory.initial", "");

But this method invocation will not to be removed:

String initial = "java.naming.factory.initial"

Hashtable ht = new Hashtable();
ht.put(initial, "");

The method invocation should be removed in both cases.

Anyone you would like to review specifically?

@timtebeek
@cjobinabo

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

[cjobinabo]

Looks good, I just left a comment wonder if we can do some additional cleanup after the method removal

[cjobinabo]

Perhaps we can do some additional cleanup here to remove these now unused variables. It looks like the org.openrewrite.staticanalysis.RemoveUnusedLocalVariables recipe could do this for us