Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle jenkins.baseline on AddPluginsPom #77

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

jonesbusy
Copy link
Collaborator

@jonesbusy jonesbusy commented Nov 7, 2024

What's changed?

Handle presence of jenkins.baseline on artifact ID.

Doesn't perform migration by adding the jenkins.baseline property which should be done at some point

What's your motivation?

Jenkins changed their archetype to include the jenkins.baseline property

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@jonesbusy jonesbusy force-pushed the feature/handle-bom-baseline branch from 438845e to dcac39a Compare November 7, 2024 16:55
build.gradle.kts Outdated Show resolved Hide resolved
@jonesbusy jonesbusy force-pushed the feature/handle-bom-baseline branch 2 times, most recently from 07154ab to 828d880 Compare November 7, 2024 17:02
@jonesbusy jonesbusy marked this pull request as ready for review November 7, 2024 17:02
@jonesbusy jonesbusy requested a review from timtebeek November 7, 2024 17:04
@jonesbusy jonesbusy force-pushed the feature/handle-bom-baseline branch 3 times, most recently from ba91eb0 to 03742ee Compare November 11, 2024 10:21
@jonesbusy jonesbusy force-pushed the feature/handle-bom-baseline branch from 03742ee to 9d915d6 Compare November 11, 2024 10:27
@jonesbusy
Copy link
Collaborator Author

Thanks for the help @timtebeek this is now ready for rewiew

@jonesbusy
Copy link
Collaborator Author

FYI @gounthar

@gounthar
Copy link
Contributor

Thanks!

Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jonesbusy !

@timtebeek timtebeek added the bug Something isn't working label Nov 11, 2024
@jonesbusy jonesbusy merged commit c08e927 into openrewrite:main Nov 11, 2024
2 checks passed
@jonesbusy jonesbusy deleted the feature/handle-bom-baseline branch November 11, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants