Add Makefile for packaging #95
Conversation
| python setup.py sdist | ||
|
|
||
| package-wheel: package-deps | ||
| python setup.py bdist_wheel --universal |
There was a problem hiding this comment.
I'm not sure the --universal flag is correct here, since we only partially support Python 3. (See https://packaging.python.org/distributing/#universal-wheels) However, if we remove it, I suspect we'll forget to add it back once Python 3 support is more robust. Thoughts?
There was a problem hiding this comment.
I'm fine keeping it right now for the sake of testing, as long as we've clearly documented the Python 3 support as WIP.
Makefile
Outdated
| .PHONY: clean package package-deps package-source package-upload package-wheel | ||
|
|
||
| package-deps: | ||
| pip install --upgrade twine wheel |
There was a problem hiding this comment.
Let's set versions on these for ease of reproduceability.
There was a problem hiding this comment.
Alternately, maybe make a development requirements.txt?
| python setup.py sdist | ||
|
|
||
| package-wheel: package-deps | ||
| python setup.py bdist_wheel --universal |
There was a problem hiding this comment.
I'm fine keeping it right now for the sake of testing, as long as we've clearly documented the Python 3 support as WIP.
Add a makefile to simplify making and uploading a package to PyPI. I haven't used this for a FIDO release yet, but have used a similar makefile for other projects.
To use, run
make packagefrom the directory with the Makefile.make cleanwill remove all packaging related artifacts.