Remove setuptools dependency #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlwilson
approved these changes
May 12, 2020
fido does not need setuptools to run correctly and the requirement is considered unsafe.
sevein
force-pushed
the
dev/issue-187-setuptools
branch
from
0730a6b to
55ec7d8
Compare
|
@carlwilson, I'm not authorized to merge. Can you do it? I had to push a linter fix. |
We can have a look at setting up a proper review and test cycle on here soon I think. Once passed tests and a review is compulsory we can open up the merge list a little. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fido does not need setuptools to run correctly and the requirement is considered unsafe.
I don't expect this to be a breaking change but I'd be curious to hear your thoughts. I've found that pytest was also listing setuptools but they stopped doing so in pytest v4.6.0 (commit pytest-dev/pytest@13f02af), presumably because they were already using
setup_requires.Fixes #187.