Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT - Test coverage reporting and publication #108

Merged
merged 1 commit into from
Jun 27, 2017
Merged

Conversation

carlwilson
Copy link
Member

  • install pytest-cov for generating coverage data;
  • install codecov to publish coverage figures on CodeCov;
  • install codacy-coverage to publish coverage figures on Codacy;
  • removed sudo from pip install as this meant fido dependencies weren't installed in Travis' env;
  • pytest call runs tests and generates coverage data; and
  • after_success: then generates coverage report in xml and pushes to CodeCov and Codacy.

- install `pytest-cov` for generating coverage data;
- install `codecov` to publish coverage figures on [CodeCov](https://codecov.io/);
- install `codacy-coverage` to publish coverage figures on [Codacy](https://www.codacy.com/app/openpreserve/fido/dashboard);
- removed `sudo` from pip install as this meant fido dependencies weren't installed in Travis' env;
- `pytest` call runs tests and generates coverage data; and
- `after_success:` then generates coverage report in xml and pushes to CodeCov and Codacy.

Removed sudo install as can't replicate build error.
Copy link
Contributor

@mistydemeo mistydemeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason this uploads coverage data to two services?

@carlwilson
Copy link
Member Author

So the two services do slightly different things. Overall Codacy is the nicer service, it carries out static code analysis and also publishes coverage stats. CodeCov is strictly coverage only but has a nicer interface for browsing coverage figures. Medium term plan would be to use one for low-level unit test coverage (CodeCov?) and Codacy to carry out static analysis and publish coverage figures for higher level integration tests.

Copy link
Contributor

@sevein sevein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sevein sevein added this to the 1.3.6 milestone Jun 26, 2017
@jhsimpson jhsimpson merged commit 4288fc0 into master Jun 27, 2017
@ablwr ablwr deleted the feat/test-coverage branch September 6, 2018 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants