update_signatures.py: add CLI options, new debug option #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistydemeo
force-pushed
the
update_signatures_options
branch
from
a81f2ce to
de0e404
Compare
This is useful for debugging.
mistydemeo
force-pushed
the
update_signatures_options
branch
8 times, most recently
from
dd1271a to
3e3cc2d
Compare
|
It turned out we were importing and calling the |
Hwesta
approved these changes
Mar 17, 2017
fido/update_signatures.py
Outdated
| parser.add_argument('-http_throttle', default=options['http_throttle'], help='Time (in seconds) to wait between downloads', type=float, dest='http_throttle') | ||
| args = parser.parse_args() | ||
| opts = defaults.copy() | ||
| opts.update(args.__dict__) |
There was a problem hiding this comment.
I think vars(args) is more appropriate here. It accesses the namespace's dict, but without using a __ function.
mistydemeo
force-pushed
the
update_signatures_options
branch
from
3e3cc2d to
05f4508
Compare
sevein
approved these changes
Jun 26, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For debugging, I find it really useful to be able to control several of the defaults used by
update_signatures. I also find it really useful to be able to disable deleting the temporary directory. I was debugging a bug that happens between downloading files and running the steps in thepreparemodule, which also happens to be where the temp files get deleted - a lesson I learned the hard way!