Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move bet validation to Bet data type #273

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

move bet validation to Bet data type #273

wants to merge 12 commits into from

Conversation

ajlacey
Copy link
Collaborator

@ajlacey ajlacey commented Aug 24, 2024

This PR is not ready.
It:

  • adds a Bets type to enable operating on multiple Bets at once
  • moves ValidateBuy to models/bets
  • updates function signature for ValdiateBuy to be a method on the Bet type, and to remove the Bet parameter from the signature

TODO:

  • add test case for valid Bets
  • add remaining test cases for invalid Bets
  • add ability to use a test double in place of gorm db

@pwdel pwdel marked this pull request as draft August 25, 2024 12:36
@pwdel
Copy link
Member

pwdel commented Aug 25, 2024

Converted to draft since you mention not yet ready. You can un-convert when it's ready by clicking, "Ready for review" toward the bottom.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants