Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --uns_merge_mode parameter to concatenate_h5mu #859

Conversation

DriesSchaumont
Copy link
Member

Changelog

Add --uns_merge_mode parameter to concatenate_h5mu

Issue ticket number and link

Closes #584 (Replace xxxx with the GitHub issue number)

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributor's guide

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI tests succeed!

@DriesSchaumont DriesSchaumont marked this pull request as ready for review August 14, 2024 13:24
…nt-that-resides-in-its-individual-modality-h5mu
…-h5mu-has-not-all-content-that-resides-in-its-individual-modality-h5mu
Copy link
Contributor

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, this needs to be updated for viash 0.9

@DriesSchaumont DriesSchaumont merged commit 6165954 into main Aug 30, 2024
3 checks passed
@DriesSchaumont DriesSchaumont deleted the 584-combined-modality-h5mu-has-not-all-content-that-resides-in-its-individual-modality-h5mu branch December 14, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combined modality h5mu has not all content that resides in its individual modality h5mu
2 participants