scANVI annotation component #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorien-er
requested changes
Aug 16, 2024
src/annotate/scanvi/config.vsh.yaml
Outdated
| required: false | ||
|
|
||
| - name: SCANVI arguments | ||
| description: Arguments related to the SCANVI model. |
There was a problem hiding this comment.
Might be neater to restructure all the model-related argument groups, e.g. 'scVI pre-trained model' and 'SCANVI training arguments' could make sense
There was a problem hiding this comment.
to not use the same params for refining the reference model from scvi and tuning the query one after?
|
|
||
| logger.info("Updating with query data") | ||
|
|
||
| scvi.model.SCANVI.prepare_query_anndata(query, scanvi_ref, inplace=True) |
There was a problem hiding this comment.
it's recomended from the tutorials
… 826-scanvi-annotation-component
… 826-scanvi-annotation-component
DriesSchaumont
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
scANVI annotation component
Issue ticket number and link
Closes #826
Checklist before requesting a review
I have performed a self-review of my code
Conforms to the Contributor's guide
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI tests succeed!