Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Viash to 0.9.0-RC7 #796

Merged
merged 77 commits into from
Aug 30, 2024
Merged

Conversation

jakubmajercik
Copy link
Collaborator

@jakubmajercik jakubmajercik commented Apr 26, 2024

Changelog

Refactored component configs:

  • the platforms field into runners and engines
  • remove the functionality field
  • make sure all tests pass

Branched out from main and develop - certain new components might not be included

All components passed the tests apart from the interactive namespace due to issues with ports as specified in docker_run_args

Issue ticket number and link

Closes #776

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributor's guide

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI tests succeed!

VladimirShitov and others added 18 commits March 25, 2024 11:35
Co-authored-by: Dries Schaumont <5946712+DriesSchaumont@users.noreply.github.com>
* stdout/err stored on fail

Co-authored-by: Dries Schaumont <DriesSchaumont@users.noreply.github.com>

* changelog entry added + minor fixes

---------

Co-authored-by: Dries Schaumont <DriesSchaumont@users.noreply.github.com>
* cellranger mkgtf component working and tested

* removed comments

* changelog entry added

* test unique attribute in result

* multiple attribute par added

* removed unused packages

* use pytest, multiple attributes tested

---------

Co-authored-by: DriesSchaumont <5946712+DriesSchaumont@users.noreply.github.com>
Base automatically changed from develop to main June 12, 2024 14:20
@DriesSchaumont DriesSchaumont changed the title 776 refactor config new viash Update Viash to 0.9.0-RC7 Aug 23, 2024
@jakubmajercik jakubmajercik linked an issue Aug 23, 2024 that may be closed by this pull request
@DriesSchaumont DriesSchaumont merged commit 331d655 into main Aug 30, 2024
106 checks passed
@DriesSchaumont DriesSchaumont deleted the 776-refactor-config-new-viash branch August 30, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor components to use new Viash version >= 0.9.0
5 participants