Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add densmap component #748

Merged
merged 23 commits into from
Aug 14, 2024
Merged

Add densmap component #748

merged 23 commits into from
Aug 14, 2024

Conversation

jakubmajercik
Copy link
Collaborator

@jakubmajercik jakubmajercik commented Mar 18, 2024

Changelog

densMAP dimensionality reduction component implemented. Neighbor computing updated to output KNN results as input to densMAP. Test resources need to be updated to include these extra fields in the mudata/anndata objects.

Issue ticket number and link

Closes #739

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributor's guide

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI tests succeed! - failing due to modified neighbor computing component.

@jakubmajercik jakubmajercik self-assigned this Mar 18, 2024
@jakubmajercik jakubmajercik linked an issue Mar 18, 2024 that may be closed by this pull request
@DriesSchaumont DriesSchaumont changed the base branch from main to develop March 27, 2024 08:10
Base automatically changed from develop to main June 12, 2024 14:20
@DriesSchaumont
Copy link
Member

@jakubmajercik Seems like something went wrong after you recent updates, care to have a look? 😃

@jakubmajercik
Copy link
Collaborator Author

jakubmajercik commented Aug 14, 2024

@jakubmajercik Seems like something went wrong after you recent updates, care to have a look? 😃

The tests fail because neighbors/find_neighbors was also modified so resources_test_scripts/pbmc_1k_protein_v3.sh needs to be rerun so that resources_test/pbmc_1k_protein_v3/pbmc_1k_protein_v3_mms.h5mu is updated. Then it works locally at least :)

@DriesSchaumont
Copy link
Member

@jakubmajercik Seems like something went wrong after you recent updates, care to have a look? 😃

The tests fail because neighbors/find_neighbors was also modified so resources_test_scripts/pbmc_1k_protein_v3.sh needs to be rerun so that resources_test/pbmc_1k_protein_v3/pbmc_1k_protein_v3_mms.h5mu is updated. Then it works locally at least :)

Of course! I keep forgetting to update the test resources 👀

@DriesSchaumont DriesSchaumont merged commit 53fa102 into main Aug 14, 2024
@DriesSchaumont DriesSchaumont deleted the 739-add-densmap-component branch August 14, 2024 15:17
DriesSchaumont added a commit that referenced this pull request Aug 16, 2024
DriesSchaumont added a commit that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add densMAP component
2 participants