Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update anndata to 0.10.8 and mudata to 0.2.4 #646

Merged
merged 29 commits into from
Aug 9, 2024
Merged

Update anndata to 0.10.8 and mudata to 0.2.4 #646

merged 29 commits into from
Aug 9, 2024

Conversation

DriesSchaumont
Copy link
Member

@DriesSchaumont DriesSchaumont commented Jan 7, 2024 •
edited
Loading

Changelog

Merge #645 first!

Issue ticket number and link

Closes #xxxx (Replace xxxx with the GitHub issue number)

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributor's guide

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes

  • Proposed changes are described in the CHANGELOG.md

  • CI tests succeed!

@DriesSchaumont
Copy link
Member Author

Because there are some issues with the from_bdrhap_to_h5mu and potentially other issues (reports on failing to store sparse matrices in .layers), lets leave this PR alone for a while..

@DriesSchaumont DriesSchaumont changed the title Update anndata to 0.10.4 and mudata to 0.2.3 Update anndata to 0.10.5.post1 and mudata to 0.2.3 Feb 14, 2024
@DriesSchaumont DriesSchaumont changed the title Update anndata to 0.10.5.post1 and mudata to 0.2.3 Update anndata to 0.11.0 and mudata to 0.2.3 Mar 14, 2024
@DriesSchaumont DriesSchaumont changed the title Update anndata to 0.11.0 and mudata to 0.2.3 Update anndata to 0.10.8 and mudata to 0.2.4 Jul 9, 2024
@DriesSchaumont DriesSchaumont marked this pull request as ready for review July 10, 2024 08:23
@DriesSchaumont DriesSchaumont requested a review from rcannood July 10, 2024 08:23
rcannood
rcannood reviewed Aug 9, 2024
View reviewed changes
Copy link
Contributor

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Do the tests succeed with the current main?
  • See other comment

rcannood
rcannood approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DriesSchaumont DriesSchaumont merged commit 2c4a107 into main Aug 9, 2024
5 checks passed
@DriesSchaumont DriesSchaumont deleted the update_anndata_mudata branch August 9, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcannood rcannood rcannood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DriesSchaumont @rcannood