-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add to news closed issues #425
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we run the tests of Tim (watchdog) for CRAN release?
I'll look in to it and run it prior to submission |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost there!
What changes are proposed in this pull request?
Review and complete the updates to the News.md file since prior release.
Updates to README ahead of release.
TODO: Do we need a pkgdown badge on the README (and subsequently the website)?
Which files are involved in this pull request and what changes were made?
N/A
Did you include unit tests for the proposed change/bug fix (https://testthat.r-lib.org/)?
N/A
If there is an GitHub issue associated with this pull request, please provide link.
closes #420
closes #424
Checklist for PR reviewer
_pkgdown.yml
pkgdown::build_site()
. Check the R console for errors, and review the rendered website.withr::with_envvar(new = c("NOT_CRAN" = "true"), covr::report())
. Before you run, begin a fresh R session without any packages loaded.usethis::use_spell_check()
runs with no spelling errors in documentationNEWS.md
been updated with the changes from this pull request under the heading indicating the latest version. If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.md
for examples).usethis::use_version(which = "dev")
devtools::build_readme()
to build theREADME.md
file.