-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed bug in generate_data and adapted tests #29
Conversation
Code Coverage Summary
Diff against main
Results for commit: b8b9db0 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Thanks @kuenzelt for working on this, can you please add a test that can show that there is this bug? Meaning, if you execute that particular test, it will fail with the current version of the package. |
Unit Test Performance DifferenceAdditional test case details
Results for commit 3f1df3b ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super, plus we need the NEWS
entry
Co-authored-by: Daniel Sabanes Bove <danielinteractive@users.noreply.github.com>
Unit Tests Summary 1 files 7 suites 1s ⏱️ Results for commit b8b9db0. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kuenzelt , I just did some last touches (version update, minor polishing on the NEWS). Good to merge as soon checks pass, and then you can build the package and submit to CRAN. Please let me know if you have any questions
closes #28