Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inc_prop only returned ae=1 var=0 on certain platforms. #22

Merged
merged 2 commits into from
Feb 7, 2024
Merged

inc_prop only returned ae=1 var=0 on certain platforms. #22

merged 2 commits into from
Feb 7, 2024

Conversation

kuenzelt
Copy link
Collaborator

@kuenzelt kuenzelt commented Feb 7, 2024

testthat has been updated to match structure of other tests

inc_prop only returned ae=1 var=0 on certain platforms. Issue is fixe…
07252a7 
…d now.

testthat has been updated to match structure of other tests
@kuenzelt kuenzelt self-assigned this Feb 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2024 •
edited
Loading

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ---------
R/aalen_johansen.R               65       0  100.00%
R/generate_data.R                27       0  100.00%
R/inc_prop.R                     10       0  100.00%
R/one_minus_kaplan_meier.R       24       0  100.00%
R/prop_trans_inc_dens_ce.R       26       0  100.00%
R/prop_trans_inc_dens.R          13       0  100.00%
TOTAL                           165       0  100.00%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 9d59810

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2024 •
edited
Loading

Unit Tests Summary

 1 files   6 suites   0s ⏱️
10 tests 10 ✅ 0 💤 0 ❌
13 runs  13 ✅ 0 💤 0 ❌

Results for commit 9d59810.

♻️ This comment has been updated with latest results.

danielinteractive
danielinteractive approved these changes Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@danielinteractive danielinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, thanks @kuenzelt !

danielinteractive
danielinteractive reviewed Feb 7, 2024
View reviewed changes
R/inc_prop.R Outdated Show resolved Hide resolved
@kuenzelt @danielinteractive
Update R/inc_prop.R
9d59810 
Co-authored-by: Daniel Sabanes Bove <danielinteractive@users.noreply.github.com>
@danielinteractive
Copy link
Collaborator

Ready to merge 👍🏼

@kuenzelt kuenzelt merged commit 1f86cc8 into main Feb 7, 2024
23 checks passed
@kuenzelt kuenzelt deleted the inc_prop_update branch February 7, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielinteractive danielinteractive danielinteractive approved these changes

Assignees

@kuenzelt kuenzelt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kuenzelt @danielinteractive