Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In memory db #553

Merged
merged 3 commits into from
Dec 29, 2022
Merged

In memory db #553

merged 3 commits into from
Dec 29, 2022

Conversation

Y-Less
Copy link
Collaborator

@Y-Less Y-Less commented Dec 28, 2022

My attempt at #547

@Y-Less
Copy link
Collaborator Author

Y-Less commented Dec 28, 2022

You'll notice:

https://github.com/openmultiplayer/open.mp/pull/553/files#diff-ae0442be1191ac118f27664b290559d196c369fd5c373b25a40b587ad3d8a16cR69-R73

Whether that's uncommented or not will determine a lot in terms of what semantics we want to allow. Should people be able to access other places on the disk? That somewhat defeats the purpose of scriptfiles/ as a sandbox.

@Y-Less
Copy link
Collaborator Author

Y-Less commented Dec 28, 2022

In response to @AmyrAhmady:

The reason I didn't go that way to support all possible in-memory database methods, is to support opening databases in a more standard way, support everything and not just absolute DB path on disk
https://www.sqlite.org/c3ref/open.html#urifilenameexamples
https://www.sqlite.org/inmemorydb.html

The commented out bit will allow any path, the rest of the code covers even more in-memory creation methods than yours had.

@AmyrAhmady AmyrAhmady merged commit a1c5e8b into master Dec 29, 2022
@AmyrAhmady AmyrAhmady deleted the in-memory-db-pr branch December 29, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants