Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add server offline status #273

Closed

Conversation

itsneufox
Copy link
Contributor

@itsneufox itsneufox commented Jan 1, 2025

This PR solves issue #194

Test to prove it works and to see how it works:
https://www.youtube.com/watch?v=aSDPU6U4dp4

edit: fixed bad encoding, sorry

@AmyrAhmady
Copy link
Member

The reason this isn't added is because your internet might be not good enough or server might have a firewall rule to skip some requests and process only like one in five requests, and that way omp launcher thinks server is offline, which it isn't. There's no need for this PR

@AmyrAhmady AmyrAhmady closed this Jan 1, 2025
@itsneufox
Copy link
Contributor Author

itsneufox commented Jan 1, 2025

The reason this isn't added is because your internet might be not good enough or server might have a firewall rule to skip some requests and process only like one in five requests, and that way omp launcher thinks server is offline, which it isn't. There's no need for this PR

then, can't we handle it in a way that it shows 0 ping? because when the server is offline, it almost looks like its online. IMO that is kinda stupid

image

can't we just remove the (Offline) tag and keep the gray color on offline servers?

@AmyrAhmady
Copy link
Member

I'll think of a way to o this properly , but only when you launch the app at first
detecting offline servers after they become offline while launcher is open is not neither needed nor necessary, just like how samp launcher works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants