FM-635: fix unit test failure depending on execution order #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you forget to update the ticket with the error logs? |
|
Sorry, added the stacktrace of the failed test as well as a guide to reproduce the behavior. |
|
Hmmm... I'd prefer a fix for this that didn't rely on extending |
|
Alternative fix that addresses the issue of at least that particular test sequence: #538 |
Move shouldUseDefaultNameTemplateToSetNameText to separate class in order to assure global variable reset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what I changed
In PersonNameTranslatorImplTest, the AdministrationService is now no longer being replaced by a mock, instead the required global property is now set in the existing AdministrationService. The replacement with a mock lead to issues when ValueSetTranslatorImplTest was run afterwards, as it requires another global property. This happened on my local machine.
Issue I worked on
see https://issues.openmrs.org/browse/FM2-635
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
I have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
I ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
All new and existing tests passed.
My pull request is based on the latest changes of the master branch.