Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) O3-3177: Extra horizontal padding on patient lists page #1423

Merged

Conversation

harshthakkr
Copy link
Contributor

@harshthakkr harshthakkr commented Dec 24, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR addresses an issue where extra horizontal padding was present on the Patient Lists page. The unnecessary padding has been removed to improve the page’s layout and ensure consistency with the overall design.

Screenshots

Before:
Screenshot 2024-12-24 at 10 59 51 PM

After:
Screenshot 2024-12-24 at 10 57 54 PM

Related Issue

O3-3177

@harshthakkr
Copy link
Contributor Author

Hi, @denniskigen @brandones, could you please take a moment to review this PR? Thank you!

Copy link
Contributor

@brandones brandones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this completely addresses the differences with the designs that Paul was pointing out in that ticket, but this is definitely a good step. Thank you!

@brandones brandones merged commit 0de1439 into openmrs:main Jan 3, 2025
6 checks passed
@harshthakkr harshthakkr deleted the fix/remove-padding-in-patient-lists-page branch January 8, 2025 03:48
@ciaranduffy
Copy link

@harshthakkr: @brandones is correct, the change in this PR does not address the differences that were highlighted in the original ticket. The 16px gap between the tab and the left nav is supposed to be there, please reverse that change.

You can see the intended layout of the page on this (old) mock-up https://zpl.io/VOLvn8Y.

@harshthakkr
Copy link
Contributor Author

Thank you for the clarification, @ciaranduffy. I’ll reverse the change and ensure it aligns with the intended layout as shown in the mock-up.

@harshthakkr harshthakkr restored the fix/remove-padding-in-patient-lists-page branch January 8, 2025 12:19
@harshthakkr
Copy link
Contributor Author

Here is the PR which reverts all the changes. @ciaranduffy

@harshthakkr harshthakkr deleted the fix/remove-padding-in-patient-lists-page branch January 11, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants