(refactor) O3-3806: Refactor Service queue entries api call using OpenMrs Fetch All #1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandones
requested changes
Dec 19, 2024
| isEnded: false, | ||
| }); | ||
|
|
||
| const { data } = useSWR<QueueEntryResponse>( |
There was a problem hiding this comment.
You are no longer using useQueueEntries at all. I can't imagine that this works in cases where the number of entries exceeds the page size. I did my development and testing of this feature by creating 11 service queue entries and setting the page size to 3. I recommend you do something similar. There are a lot of edge cases that we need to make sure will continue to work.
| const stillWaitingForMutate = waitingForMutate && !isValidating; | ||
| if (waitingForMutate && isValidating) { | ||
| setWaitingForMutate(false); | ||
| if (initialMount) { |
There was a problem hiding this comment.
First off, this initialMount is a ref, so it is always true. You want initialMount.current.
But moreover, if pageUrl changes, then useOpenmrsFetchAll will get called with the new value of pageUrl as a parameter. Why would you call mutate at the same time?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
To use hooks already present in esm-core to fetch all the queue entries.
388370799-867ef32b-fb36-4a01-a49b-c5fbf7d3b0ff.webm
Related Issue
https://openmrs.atlassian.net/browse/O3-3806
Other