Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) Fix react hooks exhaustive deps warnings #1380

Merged
merged 2 commits into from
Nov 22, 2024
Merged

(fix) Fix react hooks exhaustive deps warnings #1380

merged 2 commits into from
Nov 22, 2024

Conversation

denniskigen
Copy link
Member

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR fixes exhaustive deps warnings for React hooks flagged by the React hooks ESLint plugin.

Screenshots

Related Issue

Other

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 19, 2024 •
edited
Loading

Size Change: +490 B (+0.01%)

Total Size: 6.68 MB

ℹ️ View Unchanged
Filename Size Change
packages/esm-active-visits-app/dist/106.js 8.63 kB 0 B
packages/esm-active-visits-app/dist/130.js 394 kB 0 B
packages/esm-active-visits-app/dist/233.js 3.37 kB 0 B
packages/esm-active-visits-app/dist/236.js 614 B 0 B
packages/esm-active-visits-app/dist/240.js 615 B 0 B
packages/esm-active-visits-app/dist/261.js 615 B 0 B
packages/esm-active-visits-app/dist/271.js 800 B 0 B
packages/esm-active-visits-app/dist/272.js 615 B 0 B
packages/esm-active-visits-app/dist/316.js 42.9 kB 0 B
packages/esm-active-visits-app/dist/319.js 712 B 0 B
packages/esm-active-visits-app/dist/325.js 3.09 kB 0 B
packages/esm-active-visits-app/dist/336.js 614 B 0 B
packages/esm-active-visits-app/dist/378.js 730 B 0 B
packages/esm-active-visits-app/dist/443.js 6.98 kB 0 B
packages/esm-active-visits-app/dist/460.js 817 B 0 B
packages/esm-active-visits-app/dist/539.js 613 B 0 B
packages/esm-active-visits-app/dist/574.js 615 B 0 B
packages/esm-active-visits-app/dist/586.js 53.5 kB 0 B
packages/esm-active-visits-app/dist/6.js 26.4 kB +1 B (0%)
packages/esm-active-visits-app/dist/644.js 800 B 0 B
packages/esm-active-visits-app/dist/673.js 615 B 0 B
packages/esm-active-visits-app/dist/705.js 615 B 0 B
packages/esm-active-visits-app/dist/711.js 615 B 0 B
packages/esm-active-visits-app/dist/725.js 643 B 0 B
packages/esm-active-visits-app/dist/727.js 615 B 0 B
packages/esm-active-visits-app/dist/737.js 615 B 0 B
packages/esm-active-visits-app/dist/744.js 843 B 0 B
packages/esm-active-visits-app/dist/757.js 731 B 0 B
packages/esm-active-visits-app/dist/784.js 2.63 kB 0 B
packages/esm-active-visits-app/dist/788.js 628 B 0 B
packages/esm-active-visits-app/dist/807.js 959 B 0 B
packages/esm-active-visits-app/dist/814.js 3.04 kB 0 B
packages/esm-active-visits-app/dist/833.js 765 B 0 B
packages/esm-active-visits-app/dist/879.js 3.02 kB 0 B
packages/esm-active-visits-app/dist/899.js 611 B 0 B
packages/esm-active-visits-app/dist/967.js 611 B 0 B
packages/esm-active-visits-app/dist/main.js 82.1 kB +1 B (0%)
packages/esm-active-visits-app/dist/openmrs-esm-active-visits-app.js 3.32 kB 0 B
packages/esm-appointments-app/dist/130.js 394 kB 0 B
packages/esm-appointments-app/dist/171.js 223 B 0 B
packages/esm-appointments-app/dist/198.js 250 kB 0 B
packages/esm-appointments-app/dist/2.js 2.23 kB 0 B
packages/esm-appointments-app/dist/228.js 2.02 kB 0 B
packages/esm-appointments-app/dist/236.js 2.02 kB 0 B
packages/esm-appointments-app/dist/240.js 2.02 kB 0 B
packages/esm-appointments-app/dist/261.js 2.02 kB 0 B
packages/esm-appointments-app/dist/265.js 1.79 kB 0 B
packages/esm-appointments-app/dist/269.js 7.38 kB 0 B
packages/esm-appointments-app/dist/271.js 2.41 kB 0 B
packages/esm-appointments-app/dist/272.js 2.02 kB 0 B
packages/esm-appointments-app/dist/319.js 2.27 kB 0 B
packages/esm-appointments-app/dist/325.js 3.08 kB 0 B
packages/esm-appointments-app/dist/336.js 2.02 kB 0 B
packages/esm-appointments-app/dist/372.js 2.57 kB 0 B
packages/esm-appointments-app/dist/378.js 2.26 kB 0 B
packages/esm-appointments-app/dist/440.js 16.6 kB 0 B
packages/esm-appointments-app/dist/460.js 2.44 kB 0 B
packages/esm-appointments-app/dist/501.js 7.02 kB 0 B
packages/esm-appointments-app/dist/539.js 2.02 kB 0 B
packages/esm-appointments-app/dist/574.js 2.02 kB 0 B
packages/esm-appointments-app/dist/581.js 9.03 kB 0 B
packages/esm-appointments-app/dist/591.js 16.8 kB 0 B
packages/esm-appointments-app/dist/644.js 2.41 kB 0 B
packages/esm-appointments-app/dist/673.js 2.02 kB 0 B
packages/esm-appointments-app/dist/705.js 2.02 kB 0 B
packages/esm-appointments-app/dist/711.js 130 kB -2 B (0%)
packages/esm-appointments-app/dist/727.js 2.02 kB 0 B
packages/esm-appointments-app/dist/737.js 2.02 kB 0 B
packages/esm-appointments-app/dist/744.js 2.54 kB 0 B
packages/esm-appointments-app/dist/757.js 2.4 kB 0 B
packages/esm-appointments-app/dist/784.js 2.62 kB 0 B
packages/esm-appointments-app/dist/787.js 31.4 kB 0 B
packages/esm-appointments-app/dist/788.js 2.02 kB 0 B
packages/esm-appointments-app/dist/807.js 2.65 kB 0 B
packages/esm-appointments-app/dist/833.js 2.37 kB 0 B
packages/esm-appointments-app/dist/899.js 2.02 kB 0 B
packages/esm-appointments-app/dist/903.js 866 B +1 B (+0.12%)
packages/esm-appointments-app/dist/main.js 396 kB +4 B (0%)
packages/esm-appointments-app/dist/openmrs-esm-appointments-app.js 3.56 kB 0 B
packages/esm-bed-management-app/dist/130.js 394 kB 0 B
packages/esm-bed-management-app/dist/148.js 1.35 kB 0 B
packages/esm-bed-management-app/dist/169.js 6.98 kB 0 B
packages/esm-bed-management-app/dist/236.js 670 B 0 B
packages/esm-bed-management-app/dist/240.js 671 B 0 B
packages/esm-bed-management-app/dist/261.js 671 B 0 B
packages/esm-bed-management-app/dist/271.js 671 B 0 B
packages/esm-bed-management-app/dist/272.js 671 B 0 B
packages/esm-bed-management-app/dist/319.js 786 B 0 B
packages/esm-bed-management-app/dist/325.js 3.09 kB 0 B
packages/esm-bed-management-app/dist/336.js 672 B 0 B
packages/esm-bed-management-app/dist/339.js 50.9 kB 0 B
packages/esm-bed-management-app/dist/378.js 776 B 0 B
packages/esm-bed-management-app/dist/455.js 26.5 kB 0 B
packages/esm-bed-management-app/dist/460.js 671 B 0 B
packages/esm-bed-management-app/dist/501.js 7.03 kB 0 B
packages/esm-bed-management-app/dist/539.js 671 B 0 B
packages/esm-bed-management-app/dist/542.js 395 B 0 B
packages/esm-bed-management-app/dist/574.js 781 B 0 B
packages/esm-bed-management-app/dist/591.js 16.8 kB 0 B
packages/esm-bed-management-app/dist/644.js 671 B 0 B
packages/esm-bed-management-app/dist/673.js 672 B 0 B
packages/esm-bed-management-app/dist/705.js 671 B 0 B
packages/esm-bed-management-app/dist/711.js 671 B 0 B
packages/esm-bed-management-app/dist/727.js 671 B 0 B
packages/esm-bed-management-app/dist/737.js 671 B 0 B
packages/esm-bed-management-app/dist/744.js 863 B 0 B
packages/esm-bed-management-app/dist/757.js 814 B 0 B
packages/esm-bed-management-app/dist/766.js 113 kB 0 B
packages/esm-bed-management-app/dist/784.js 2.63 kB 0 B
packages/esm-bed-management-app/dist/788.js 671 B 0 B
packages/esm-bed-management-app/dist/807.js 671 B 0 B
packages/esm-bed-management-app/dist/833.js 671 B 0 B
packages/esm-bed-management-app/dist/899.js 670 B 0 B
packages/esm-bed-management-app/dist/main.js 4.01 kB 0 B
packages/esm-bed-management-app/dist/openmrs-esm-bed-management-app.js 3.25 kB 0 B
packages/esm-patient-list-management-app/dist/130.js 394 kB 0 B
packages/esm-patient-list-management-app/dist/233.js 3.38 kB 0 B
packages/esm-patient-list-management-app/dist/236.js 1.34 kB 0 B
packages/esm-patient-list-management-app/dist/240.js 1.34 kB 0 B
packages/esm-patient-list-management-app/dist/261.js 1.34 kB 0 B
packages/esm-patient-list-management-app/dist/271.js 1.6 kB 0 B
packages/esm-patient-list-management-app/dist/272.js 1.34 kB 0 B
packages/esm-patient-list-management-app/dist/319.js 1.52 kB 0 B
packages/esm-patient-list-management-app/dist/325.js 3.09 kB 0 B
packages/esm-patient-list-management-app/dist/336.js 1.34 kB 0 B
packages/esm-patient-list-management-app/dist/37.js 12.5 kB +7 B (+0.06%)
packages/esm-patient-list-management-app/dist/378.js 1.55 kB 0 B
packages/esm-patient-list-management-app/dist/443.js 6.98 kB 0 B
packages/esm-patient-list-management-app/dist/455.js 58.3 kB +32 B (+0.05%)
packages/esm-patient-list-management-app/dist/460.js 1.71 kB 0 B
packages/esm-patient-list-management-app/dist/539.js 1.34 kB 0 B
packages/esm-patient-list-management-app/dist/574.js 1.34 kB 0 B
packages/esm-patient-list-management-app/dist/591.js 16.9 kB 0 B
packages/esm-patient-list-management-app/dist/644.js 1.6 kB 0 B
packages/esm-patient-list-management-app/dist/658.js 102 kB 0 B
packages/esm-patient-list-management-app/dist/673.js 1.34 kB 0 B
packages/esm-patient-list-management-app/dist/705.js 1.34 kB 0 B
packages/esm-patient-list-management-app/dist/711.js 1.34 kB 0 B
packages/esm-patient-list-management-app/dist/727.js 1.34 kB 0 B
packages/esm-patient-list-management-app/dist/737.js 1.34 kB 0 B
packages/esm-patient-list-management-app/dist/744.js 1.72 kB 0 B
packages/esm-patient-list-management-app/dist/757.js 1.64 kB 0 B
packages/esm-patient-list-management-app/dist/784.js 2.63 kB 0 B
packages/esm-patient-list-management-app/dist/788.js 1.34 kB 0 B
packages/esm-patient-list-management-app/dist/807.js 1.83 kB 0 B
packages/esm-patient-list-management-app/dist/814.js 3.05 kB 0 B
packages/esm-patient-list-management-app/dist/833.js 1.6 kB 0 B
packages/esm-patient-list-management-app/dist/899.js 1.34 kB 0 B
packages/esm-patient-list-management-app/dist/main.js 162 kB +29 B (+0.02%)
packages/esm-patient-list-management-app/dist/openmrs-esm-patient-list-management-app.js 3.3 kB 0 B
packages/esm-patient-registration-app/dist/130.js 394 kB 0 B
packages/esm-patient-registration-app/dist/169.js 6.71 kB 0 B
packages/esm-patient-registration-app/dist/2.js 2.24 kB 0 B
packages/esm-patient-registration-app/dist/236.js 2.12 kB 0 B
packages/esm-patient-registration-app/dist/240.js 2.12 kB 0 B
packages/esm-patient-registration-app/dist/250.js 526 B 0 B
packages/esm-patient-registration-app/dist/261.js 2.12 kB 0 B
packages/esm-patient-registration-app/dist/271.js 2.51 kB 0 B
packages/esm-patient-registration-app/dist/272.js 2.12 kB 0 B
packages/esm-patient-registration-app/dist/319.js 2.42 kB 0 B
packages/esm-patient-registration-app/dist/325.js 3.09 kB 0 B
packages/esm-patient-registration-app/dist/336.js 2.12 kB 0 B
packages/esm-patient-registration-app/dist/372.js 2.57 kB 0 B
packages/esm-patient-registration-app/dist/378.js 2.37 kB 0 B
packages/esm-patient-registration-app/dist/460.js 2.49 kB 0 B
packages/esm-patient-registration-app/dist/501.js 7.03 kB 0 B
packages/esm-patient-registration-app/dist/539.js 2.12 kB 0 B
packages/esm-patient-registration-app/dist/574.js 2.12 kB 0 B
packages/esm-patient-registration-app/dist/591.js 16.8 kB 0 B
packages/esm-patient-registration-app/dist/644.js 2.51 kB 0 B
packages/esm-patient-registration-app/dist/662.js 453 B 0 B
packages/esm-patient-registration-app/dist/673.js 2.12 kB 0 B
packages/esm-patient-registration-app/dist/705.js 2.12 kB 0 B
packages/esm-patient-registration-app/dist/711.js 2.12 kB 0 B
packages/esm-patient-registration-app/dist/727.js 2.12 kB 0 B
packages/esm-patient-registration-app/dist/737.js 2.12 kB 0 B
packages/esm-patient-registration-app/dist/744.js 2.44 kB 0 B
packages/esm-patient-registration-app/dist/745.js 71.4 kB 0 B
packages/esm-patient-registration-app/dist/750.js 77.5 kB 0 B
packages/esm-patient-registration-app/dist/753.js 652 B 0 B
packages/esm-patient-registration-app/dist/757.js 2.54 kB 0 B
packages/esm-patient-registration-app/dist/784.js 2.63 kB 0 B
packages/esm-patient-registration-app/dist/788.js 2.12 kB 0 B
packages/esm-patient-registration-app/dist/807.js 2.74 kB 0 B
packages/esm-patient-registration-app/dist/833.js 2.39 kB 0 B
packages/esm-patient-registration-app/dist/879.js 3.03 kB 0 B
packages/esm-patient-registration-app/dist/899.js 2.12 kB 0 B
packages/esm-patient-registration-app/dist/main.js 149 kB 0 B
packages/esm-patient-registration-app/dist/openmrs-esm-patient-registration-app.js 3.34 kB 0 B
packages/esm-patient-search-app/dist/130.js 394 kB 0 B
packages/esm-patient-search-app/dist/173.js 26 kB 0 B
packages/esm-patient-search-app/dist/233.js 3.37 kB 0 B
packages/esm-patient-search-app/dist/236.js 799 B 0 B
packages/esm-patient-search-app/dist/240.js 801 B 0 B
packages/esm-patient-search-app/dist/261.js 801 B 0 B
packages/esm-patient-search-app/dist/271.js 1 kB 0 B
packages/esm-patient-search-app/dist/272.js 801 B 0 B
packages/esm-patient-search-app/dist/319.js 926 B 0 B
packages/esm-patient-search-app/dist/325.js 3.09 kB 0 B
packages/esm-patient-search-app/dist/336.js 800 B 0 B
packages/esm-patient-search-app/dist/378.js 952 B 0 B
packages/esm-patient-search-app/dist/443.js 6.98 kB 0 B
packages/esm-patient-search-app/dist/460.js 1.01 kB 0 B
packages/esm-patient-search-app/dist/539.js 799 B 0 B
packages/esm-patient-search-app/dist/574.js 801 B 0 B
packages/esm-patient-search-app/dist/591.js 16.8 kB 0 B
packages/esm-patient-search-app/dist/644.js 1 kB 0 B
packages/esm-patient-search-app/dist/673.js 801 B 0 B
packages/esm-patient-search-app/dist/705.js 801 B 0 B
packages/esm-patient-search-app/dist/711.js 801 B 0 B
packages/esm-patient-search-app/dist/727.js 801 B 0 B
packages/esm-patient-search-app/dist/737.js 800 B 0 B
packages/esm-patient-search-app/dist/744.js 1.04 kB 0 B
packages/esm-patient-search-app/dist/750.js 53.5 kB 0 B
packages/esm-patient-search-app/dist/757.js 953 B 0 B
packages/esm-patient-search-app/dist/784.js 2.63 kB 0 B
packages/esm-patient-search-app/dist/788.js 797 B 0 B
packages/esm-patient-search-app/dist/807.js 1.1 kB 0 B
packages/esm-patient-search-app/dist/814.js 3.05 kB 0 B
packages/esm-patient-search-app/dist/833.js 950 B 0 B
packages/esm-patient-search-app/dist/899.js 797 B 0 B
packages/esm-patient-search-app/dist/main.js 80.8 kB 0 B
packages/esm-patient-search-app/dist/openmrs-esm-patient-search-app.js 3.29 kB 0 B
packages/esm-service-queues-app/dist/1006.js 1.75 kB 0 B
packages/esm-service-queues-app/dist/1060.js 1.82 kB 0 B
packages/esm-service-queues-app/dist/1169.js 6.98 kB 0 B
packages/esm-service-queues-app/dist/130.js 394 kB 0 B
packages/esm-service-queues-app/dist/1325.js 3.09 kB 0 B
packages/esm-service-queues-app/dist/1644.js 4.6 kB 0 B
packages/esm-service-queues-app/dist/1727.js 8.1 kB 0 B
packages/esm-service-queues-app/dist/1800.js 1.67 kB 0 B
packages/esm-service-queues-app/dist/2.js 2.23 kB 0 B
packages/esm-service-queues-app/dist/236.js 3.88 kB 0 B
packages/esm-service-queues-app/dist/2757.js 4.74 kB 0 B
packages/esm-service-queues-app/dist/2760.js 7.3 kB +103 B (+1.43%)
packages/esm-service-queues-app/dist/2784.js 2.62 kB 0 B
packages/esm-service-queues-app/dist/3199.js 1.36 kB 0 B
packages/esm-service-queues-app/dist/3372.js 2.57 kB 0 B
packages/esm-service-queues-app/dist/3574.js 3.88 kB 0 B
packages/esm-service-queues-app/dist/3604.js 6.96 kB 0 B
packages/esm-service-queues-app/dist/366.js 7.86 kB 0 B
packages/esm-service-queues-app/dist/3818.js 2.56 kB +1 B (+0.04%)
packages/esm-service-queues-app/dist/3828.js 1.38 kB 0 B
packages/esm-service-queues-app/dist/4272.js 3.88 kB 0 B
packages/esm-service-queues-app/dist/4378.js 4.47 kB 0 B
packages/esm-service-queues-app/dist/4460.js 4.81 kB 0 B
packages/esm-service-queues-app/dist/4705.js 3.88 kB 0 B
packages/esm-service-queues-app/dist/4748.js 116 kB +84 B (+0.07%)
packages/esm-service-queues-app/dist/4911.js 7.76 kB 0 B
packages/esm-service-queues-app/dist/5236.js 5.99 kB +141 B (+2.41%)
packages/esm-service-queues-app/dist/5240.js 3.88 kB 0 B
packages/esm-service-queues-app/dist/5282.js 8.98 kB +12 B (+0.13%)
packages/esm-service-queues-app/dist/5336.js 3.88 kB 0 B
packages/esm-service-queues-app/dist/539.js 3.88 kB 0 B
packages/esm-service-queues-app/dist/5501.js 7.03 kB 0 B
packages/esm-service-queues-app/dist/5673.js 3.88 kB 0 B
packages/esm-service-queues-app/dist/5711.js 3.88 kB 0 B
packages/esm-service-queues-app/dist/5737.js 3.88 kB 0 B
packages/esm-service-queues-app/dist/5833.js 4.5 kB 0 B
packages/esm-service-queues-app/dist/6591.js 16.8 kB 0 B
packages/esm-service-queues-app/dist/660.js 158 kB 0 B
packages/esm-service-queues-app/dist/6670.js 10.1 kB +1 B (+0.01%)
packages/esm-service-queues-app/dist/6727.js 3.88 kB 0 B
packages/esm-service-queues-app/dist/744.js 4.71 kB 0 B
packages/esm-service-queues-app/dist/752.js 1.62 kB 0 B
packages/esm-service-queues-app/dist/7807.js 5.16 kB 0 B
packages/esm-service-queues-app/dist/8271.js 4.6 kB 0 B
packages/esm-service-queues-app/dist/8319.js 4.34 kB 0 B
packages/esm-service-queues-app/dist/8788.js 3.89 kB 0 B
packages/esm-service-queues-app/dist/899.js 3.88 kB 0 B
packages/esm-service-queues-app/dist/9261.js 3.88 kB 0 B
packages/esm-service-queues-app/dist/9392.js 7.85 kB 0 B
packages/esm-service-queues-app/dist/940.js 21.4 kB 0 B
packages/esm-service-queues-app/dist/main.js 275 kB +75 B (+0.03%)
packages/esm-service-queues-app/dist/openmrs-esm-service-queues-app.js 3.3 kB 0 B
packages/esm-ward-app/dist/109.js 344 B 0 B
packages/esm-ward-app/dist/124.js 3.68 kB 0 B
packages/esm-ward-app/dist/125.js 5.87 kB 0 B
packages/esm-ward-app/dist/126.js 9.63 kB 0 B
packages/esm-ward-app/dist/130.js 394 kB 0 B
packages/esm-ward-app/dist/146.js 2.13 kB 0 B
packages/esm-ward-app/dist/15.js 482 B 0 B
packages/esm-ward-app/dist/169.js 6.97 kB 0 B
packages/esm-ward-app/dist/303.js 33.2 kB 0 B
packages/esm-ward-app/dist/325.js 3.08 kB 0 B
packages/esm-ward-app/dist/348.js 349 B 0 B
packages/esm-ward-app/dist/372.js 2.56 kB 0 B
packages/esm-ward-app/dist/471.js 6.88 kB 0 B
packages/esm-ward-app/dist/481.js 1.25 kB 0 B
packages/esm-ward-app/dist/501.js 7.02 kB 0 B
packages/esm-ward-app/dist/53.js 12.2 kB 0 B
packages/esm-ward-app/dist/559.js 342 B 0 B
packages/esm-ward-app/dist/574.js 1.63 kB 0 B
packages/esm-ward-app/dist/576.js 5.86 kB 0 B
packages/esm-ward-app/dist/577.js 17.6 kB 0 B
packages/esm-ward-app/dist/591.js 16.8 kB 0 B
packages/esm-ward-app/dist/598.js 35.7 kB 0 B
packages/esm-ward-app/dist/649.js 2.51 kB 0 B
packages/esm-ward-app/dist/662.js 11.1 kB 0 B
packages/esm-ward-app/dist/767.js 648 B 0 B
packages/esm-ward-app/dist/784.js 2.62 kB 0 B
packages/esm-ward-app/dist/920.js 629 B 0 B
packages/esm-ward-app/dist/921.js 6.09 kB 0 B
packages/esm-ward-app/dist/922.js 9.07 kB 0 B
packages/esm-ward-app/dist/940.js 21.4 kB 0 B
packages/esm-ward-app/dist/969.js 202 B 0 B
packages/esm-ward-app/dist/main.js 40.4 kB 0 B
packages/esm-ward-app/dist/openmrs-esm-ward-app.js 3.29 kB 0 B

compressed-size-action

@denniskigen denniskigen force-pushed the fix/react-hooks-exhaustive-deps branch from 8a6f947 to 9a8aecc Compare November 20, 2024 21:21
@denniskigen denniskigen force-pushed the fix/react-hooks-exhaustive-deps branch from 7b1653a to c5e257b Compare November 21, 2024 20:13
@denniskigen
(fix) Fix react hooks exhaustive deps warnings
f7a994a 
This PR fixes exhaustive deps warnings for React hooks flagged by the React hooks ESLint plugin.
@denniskigen denniskigen force-pushed the fix/react-hooks-exhaustive-deps branch from c5e257b to f7a994a Compare November 21, 2024 20:19
chibongho
chibongho reviewed Nov 21, 2024
View reviewed changes
packages/esm-service-queues-app/src/patient-queue-header/patient-queue-header.component.tsx
error,
handleQueueLocationChange,
isLoading,
queueLocations,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate dependencies warning here.

chibongho
chibongho approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@chibongho chibongho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment. Looks good otherwise.

@denniskigen denniskigen merged commit e4e2223 into main Nov 22, 2024
6 checks passed
@denniskigen denniskigen deleted the fix/react-hooks-exhaustive-deps branch November 22, 2024 07:41
denniskigen added a commit that referenced this pull request Nov 26, 2024
@denniskigen
(fix) Fix more react hooks exhaustive deps warnings
0644261 
I don't know why these didn't show up in #1380, but they're fixed now.
@denniskigen denniskigen mentioned this pull request Nov 26, 2024
Merged
3 tasks
denniskigen added a commit that referenced this pull request Nov 27, 2024
@denniskigen
(fix) Fix more react hooks exhaustive deps warnings
2e94f7f 
I don't know why these didn't show up in #1380, but they're fixed now.
@denniskigen denniskigen mentioned this pull request Dec 17, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chibongho chibongho chibongho approved these changes

@ibacher ibacher Awaiting requested review from ibacher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denniskigen @chibongho